Code review comment for ubuntu-archive-tools:frozen-for-release

Revision history for this message
Chris Halse Rogers (raof) wrote (last edit ):

This doesn't do what you think it does; urllib.request.urlopen will *throw an exception* on HTTP error; you only get a status object back if the HTTP call doesn't fail.

So, in its current state, this makes it so that sru-release will fail with an exception when the release is not frozen, and successfully warn you that the release is frozen when it *is* frozen ☺.

review: Needs Fixing

« Back to merge proposal