Code review comment for lp:~tycho-s/maas/add-missing-node-fields
Revision history for this message
| Gavin Panella (allenap) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> On Wed, Nov 27, 2013 at 11:01:54PM -0000, Julian Edwards wrote:
> > Review: Disapprove
> >
> > Indeed - it's why they're not writable by the API or the UI, the are
> supposed
> > to come from hardware inventory. If that process is not working, we should
> > fix it, not paper over it.
> >
> > However, I'll change my vote if you can justify it :)
>
> If I create a node via `maas-cli maas nodes new', there is currently
> no way to set the hwinfo that I can see. I spoke with jtv, and he
> seemed to think this was an oversight. That said, is there any reason
> /not/ to support this? What happens if I add some RAM to a box?
In theory, that would be done by a mini-commissioning cycle. However, we don't have one, though we can force a machine through a full commissioning cycle. That means deallocating the machine from the user, which may not be desirable. There's merit in letting people fix their own data while MAAS does not provide convenient means to update itself.
I don't want to flip-flop on this, so let's see what others think. Jeroen was in favour, I'm on the fence. Does anyone else want to chime in?
As a compromise, we could land this so that people using dailies can use it. However, we'd also file a bug against 14.04 to review its inclusion in the LTS; perhaps there would be a better way to do it at that point.