Merge lp:~twstd-dev/ubuntu-calendar-app/1359306 into lp:ubuntu-calendar-app

Proposed by twstd
Status: Merged
Approved by: Mihir Soni
Approved revision: 425
Merged at revision: 432
Proposed branch: lp:~twstd-dev/ubuntu-calendar-app/1359306
Merge into: lp:ubuntu-calendar-app
Diff against target: 26 lines (+8/-0)
1 file modified
NewEvent.qml (+8/-0)
To merge this branch: bzr merge lp:~twstd-dev/ubuntu-calendar-app/1359306
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+232942@code.launchpad.net

Commit message

A fix for bug #1359306

Description of the change

Just a quick fix for a request #1359306

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Works great.

Thanks for the MR.

Revision history for this message
Mihir Soni (mihirsoni) wrote :

This branch needs merge from trunk.

review: Needs Fixing
424. By twstd

Merge with the main branch

425. By twstd

Add empty line back

Revision history for this message
twstd (twstd-dev) wrote :

Updated

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2014-08-28 23:10:33 +0000
+++ NewEvent.qml 2014-09-06 16:27:49 +0000
@@ -45,6 +45,7 @@
45 onStartDateChanged: {45 onStartDateChanged: {
46 startDateInput.text = Qt.formatDateTime(startDate, "dd MMM yyyy");46 startDateInput.text = Qt.formatDateTime(startDate, "dd MMM yyyy");
47 startTimeInput.text = Qt.formatDateTime(startDate, "hh:mm");47 startTimeInput.text = Qt.formatDateTime(startDate, "hh:mm");
48 adjustEndDateToStartDate()
48 }49 }
4950
50 onEndDateChanged: {51 onEndDateChanged: {
@@ -325,7 +326,14 @@
325 return tempDate.setHours(tempDate.getHours() + 1)326 return tempDate.setHours(tempDate.getHours() + 1)
326 }327 }
327328
329 function adjustEndDateToStartDate() {
330 // set time forward to one hour
331 var time_forward = 3600000;
332 endDate = new Date( startDate.getTime() + time_forward );
333 }
334
328 ScrollAnimation{id:scrollAnimation}335 ScrollAnimation{id:scrollAnimation}
336
329 function scrollOnExpand(Self,Container,Target,Margin,Visible)337 function scrollOnExpand(Self,Container,Target,Margin,Visible)
330 {338 {
331 // Self is needed for "onXxxxxChange" triggers. OnExpansionCompleted however can just write "true".339 // Self is needed for "onXxxxxChange" triggers. OnExpansionCompleted however can just write "true".

Subscribers

People subscribed via source and target branches

to status/vote changes: