Code review comment for lp:~twom/launchpad/branch-permissions-for-gitapi

Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks, this is looking better now. Just a few more bits and pieces.

A quick pass over the whole diff to conform to the prevailing style would be good (e.g. public methods of model objects get a """See `IFoo`.""" docstring, no blank line at the start of methods, multi-line displays generally have a newline after the opening punctuation and then a four-space indent for their contents rather than the contents being indented to the opening punctuation, etc.).

review: Approve

« Back to merge proposal