Code review comment for lp:~tveronezi/juju-gui/make-build

Revision history for this message
Thiago Veronezi (tveronezi) wrote :

Reviewers: mp+134706_code.launchpad.net,

Message:
Please take a look.

Description:
Makefile does not support static file deployment

Full description here: https://bugs.launchpad.net/juju-gui/+bug/1078898

This branch does not support CSS minification. It only combines the
third-party css files. The minification of the YUI and our custom CSS
files is covered by another branch;

The "make debug" command starts the node.js server with the debug
version of our application;

The "make server" command starts a python SimpleHTTPServer service with
the production version of our application. Note that it is not possible
to use REST with this version. It will be covered by another card;

https://code.launchpad.net/~tveronezi/juju-gui/make-build/+merge/134706

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6844061/

Affected files:
   M .bzrignore
   M Makefile
   A [revision details]
   M app/index.html
   M bin/merge-files
   M grunt.js
   M lib/server.js
   M lib/templates.js

« Back to merge proposal