Code review comment for lp:~tveronezi/juju-gui/hotkeys

>>It doesn't look like you used lbox for this, but I'm including a reply
here.
Hmmm... strange. I think I did. Well... I will try again later.

>>Y.one('doc').on('key', composeMail, 'n+ctrl')
Ah! That's good. I used something I did for another project. I will switch
to the yui stuff. Thanks!

[]s,
Thiago.

On Thu, Oct 25, 2012 at 11:42 AM, Benjamin Saller <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> It doesn't look like you used lbox for this, but I'm including a reply
> here.
>
> http://yuilibrary.com/yui/docs/event/key.html has a key filtering spec
>
> such that we can say things like
>
> // require modifier keys with +(modifier)
> Y.one('doc').on('key', composeMail, 'n+ctrl');
>
> This seems to meet our needs here and will eliminate much of the code
> included in this diff. This way we can fire directly to handlers w/o
> multiple events per keydown to do indirection like you have now.
>
> Looking forward to having keyboard shortcuts :)
>
> --
> https://code.launchpad.net/~tveronezi/juju-gui/hotkeys/+merge/131382
> You are the owner of lp:~tveronezi/juju-gui/hotkeys.
>