Merge lp:~tvansteenburgh/charms/trusty/nova-compute/fix-tests into lp:~openstack-charmers-archive/charms/trusty/nova-compute/trunk

Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 75
Proposed branch: lp:~tvansteenburgh/charms/trusty/nova-compute/fix-tests
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-compute/trunk
Diff against target: 59 lines (+23/-2)
3 files modified
Makefile (+10/-2)
README.txt (+11/-0)
config.yaml (+2/-0)
To merge this branch: bzr merge lp:~tvansteenburgh/charms/trusty/nova-compute/fix-tests
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+234035@code.launchpad.net

Description of the change

Fix tests, proof errors.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2014-08-13 15:55:07 +0000
+++ Makefile 2014-09-10 00:05:20 +0000
@@ -5,9 +5,9 @@
5 @flake8 --exclude hooks/charmhelpers hooks unit_tests5 @flake8 --exclude hooks/charmhelpers hooks unit_tests
6 @charm proof6 @charm proof
77
8test:8test: .venv
9 @echo Starting tests...9 @echo Starting tests...
10 @$(PYTHON) /usr/bin/nosetests --nologcapture --with-coverage unit_tests10 .venv/bin/nosetests --nologcapture --with-coverage unit_tests
1111
12bin/charm_helpers_sync.py:12bin/charm_helpers_sync.py:
13 @mkdir -p bin13 @mkdir -p bin
@@ -20,3 +20,11 @@
20publish: lint test20publish: lint test
21 bzr push lp:charms/nova-compute21 bzr push lp:charms/nova-compute
22 bzr push lp:charms/trusty/nova-compute22 bzr push lp:charms/trusty/nova-compute
23
24.venv:
25 sudo apt-get install python-virtualenv python-apt
26 virtualenv .venv --system-site-packages
27 .venv/bin/pip install -I nose pyyaml mock
28
29clean:
30 rm -rf .venv
2331
=== added file 'README.txt'
--- README.txt 1970-01-01 00:00:00 +0000
+++ README.txt 2014-09-10 00:05:20 +0000
@@ -0,0 +1,11 @@
1============
2nova-compute
3============
4
5Compute node for Openstack nova.
6
7OpenStack Compute, codenamed Nova, is a cloud computing fabric controller. In
8addition to its "native" API (the OpenStack API), it also supports the Amazon
9EC2 API.
10
11Maintainer: Adam Gandelman <adamg@canonical.com>
012
=== modified file 'config.yaml'
--- config.yaml 2014-09-02 15:25:14 +0000
+++ config.yaml 2014-09-10 00:05:20 +0000
@@ -91,9 +91,11 @@
91 description: Network interface on which to build bridge91 description: Network interface on which to build bridge
92 instances-path:92 instances-path:
93 type: string93 type: string
94 default:
94 description: Instance path to use - empty means default of /var/lib/nova/instances95 description: Instance path to use - empty means default of /var/lib/nova/instances
95 config-flags:96 config-flags:
96 type: string97 type: string
98 default:
97 description: Comma separated list of key=value config flags to be set in nova.conf.99 description: Comma separated list of key=value config flags to be set in nova.conf.
98 nagios_context:100 nagios_context:
99 default: "juju"101 default: "juju"

Subscribers

People subscribed via source and target branches