Merge lp:~tvansteenburgh/charms/precise/ceilometer/fix-tests into lp:~openstack-charmers-archive/charms/precise/ceilometer/trunk

Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 49
Proposed branch: lp:~tvansteenburgh/charms/precise/ceilometer/fix-tests
Merge into: lp:~openstack-charmers-archive/charms/precise/ceilometer/trunk
Diff against target: 46 lines (+9/-6)
2 files modified
config.yaml (+3/-0)
hooks/ceilometer_utils.py (+6/-6)
To merge this branch: bzr merge lp:~tvansteenburgh/charms/precise/ceilometer/fix-tests
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+234173@code.launchpad.net

Description of the change

Fix proof, lint.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-02-27 09:47:41 +0000
+++ config.yaml 2014-09-10 18:40:04 +0000
@@ -42,6 +42,7 @@
42 Setting this to True will force all services to log to the syslog.42 Setting this to True will force all services to log to the syslog.
43 ssl_cert:43 ssl_cert:
44 type: string44 type: string
45 default:
45 description: |46 description: |
46 SSL certificate to install and use for API ports. Setting this value47 SSL certificate to install and use for API ports. Setting this value
47 and ssl_key will enable reverse proxying, point Ceilometer's entry in the48 and ssl_key will enable reverse proxying, point Ceilometer's entry in the
@@ -49,9 +50,11 @@
49 issued by Keystone (if it is configured to do so).50 issued by Keystone (if it is configured to do so).
50 ssl_key:51 ssl_key:
51 type: string52 type: string
53 default:
52 description: SSL key to use with certificate specified as ssl_cert.54 description: SSL key to use with certificate specified as ssl_cert.
53 ssl_ca:55 ssl_ca:
54 type: string56 type: string
57 default:
55 description: |58 description: |
56 SSL CA to use with the certificate and key provided - this is only59 SSL CA to use with the certificate and key provided - this is only
57 required if you are providing a privately signed ssl_cert and ssl_key.60 required if you are providing a privately signed ssl_cert and ssl_key.
5861
=== modified file 'hooks/ceilometer_utils.py'
--- hooks/ceilometer_utils.py 2014-04-10 15:34:08 +0000
+++ hooks/ceilometer_utils.py 2014-09-10 18:40:04 +0000
@@ -51,12 +51,12 @@
5151
52CEILOMETER_ROLE = "ResellerAdmin"52CEILOMETER_ROLE = "ResellerAdmin"
5353
54#NOVA_CONF = "/etc/nova/nova.conf"54# NOVA_CONF = "/etc/nova/nova.conf"
55#NOVA_SETTINGS = [55# NOVA_SETTINGS = [
56# ('DEFAULT', 'instance_usage_audit', 'True'),56# ('DEFAULT', 'instance_usage_audit', 'True'),
57# ('DEFAULT', 'instance_usage_audit_period', 'hour'),57# ('DEFAULT', 'instance_usage_audit_period', 'hour'),
58# ('DEFAULT', 'notification_driver', 'ceilometer.compute.nova_notifier')58# ('DEFAULT', 'notification_driver', 'ceilometer.compute.nova_notifier')
59#]59# ]
6060
6161
62CONFIG_FILES = OrderedDict([62CONFIG_FILES = OrderedDict([

Subscribers

People subscribed via source and target branches