Merge lp:~tvansteenburgh/charms/precise/ceilometer/fix-tests into lp:~openstack-charmers-archive/charms/precise/ceilometer/trunk

Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 49
Proposed branch: lp:~tvansteenburgh/charms/precise/ceilometer/fix-tests
Merge into: lp:~openstack-charmers-archive/charms/precise/ceilometer/trunk
Diff against target: 46 lines (+9/-6)
2 files modified
config.yaml (+3/-0)
hooks/ceilometer_utils.py (+6/-6)
To merge this branch: bzr merge lp:~tvansteenburgh/charms/precise/ceilometer/fix-tests
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+234173@code.launchpad.net

Description of the change

Fix proof, lint.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-02-27 09:47:41 +0000
3+++ config.yaml 2014-09-10 18:40:04 +0000
4@@ -42,6 +42,7 @@
5 Setting this to True will force all services to log to the syslog.
6 ssl_cert:
7 type: string
8+ default:
9 description: |
10 SSL certificate to install and use for API ports. Setting this value
11 and ssl_key will enable reverse proxying, point Ceilometer's entry in the
12@@ -49,9 +50,11 @@
13 issued by Keystone (if it is configured to do so).
14 ssl_key:
15 type: string
16+ default:
17 description: SSL key to use with certificate specified as ssl_cert.
18 ssl_ca:
19 type: string
20+ default:
21 description: |
22 SSL CA to use with the certificate and key provided - this is only
23 required if you are providing a privately signed ssl_cert and ssl_key.
24
25=== modified file 'hooks/ceilometer_utils.py'
26--- hooks/ceilometer_utils.py 2014-04-10 15:34:08 +0000
27+++ hooks/ceilometer_utils.py 2014-09-10 18:40:04 +0000
28@@ -51,12 +51,12 @@
29
30 CEILOMETER_ROLE = "ResellerAdmin"
31
32-#NOVA_CONF = "/etc/nova/nova.conf"
33-#NOVA_SETTINGS = [
34-# ('DEFAULT', 'instance_usage_audit', 'True'),
35-# ('DEFAULT', 'instance_usage_audit_period', 'hour'),
36-# ('DEFAULT', 'notification_driver', 'ceilometer.compute.nova_notifier')
37-#]
38+# NOVA_CONF = "/etc/nova/nova.conf"
39+# NOVA_SETTINGS = [
40+# ('DEFAULT', 'instance_usage_audit', 'True'),
41+# ('DEFAULT', 'instance_usage_audit_period', 'hour'),
42+# ('DEFAULT', 'notification_driver', 'ceilometer.compute.nova_notifier')
43+# ]
44
45
46 CONFIG_FILES = OrderedDict([

Subscribers

People subscribed via source and target branches