Merge lp:~tvansteenburgh/charm-tools/bundle-proof-v4 into lp:charm-tools/1.6

Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 355
Proposed branch: lp:~tvansteenburgh/charm-tools/bundle-proof-v4
Merge into: lp:charm-tools/1.6
Diff against target: 62 lines (+14/-1)
3 files modified
charmtools/bundles.py (+4/-1)
tests_functional/create/test_ansible_create.py (+5/-0)
tests_functional/create/test_python_create.py (+5/-0)
To merge this branch: bzr merge lp:~tvansteenburgh/charm-tools/bundle-proof-v4
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+268596@code.launchpad.net

Description of the change

Update bundle proof for v4.

With v4, the expected bundle file name is bundle.yaml instead of
bundles.yaml.

Also fixed some charm-create tests that were failing due to new files in
charmhelpers.

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'charmtools/bundles.py'
--- charmtools/bundles.py 2014-04-02 20:32:53 +0000
+++ charmtools/bundles.py 2015-08-20 13:36:17 +0000
@@ -79,7 +79,10 @@
79class Bundle(object):79class Bundle(object):
80 def __init__(self, path, debug=False):80 def __init__(self, path, debug=False):
81 self.bundle_path = os.path.abspath(path)81 self.bundle_path = os.path.abspath(path)
82 self.supported_files = ['bundles.yaml', 'bundles.json']82 self.supported_files = [
83 'bundle.yaml', 'bundle.json', # v4
84 'bundles.yaml', 'bundles.json', # v3
85 ]
83 self.debug = debug86 self.debug = debug
84 if not self.is_bundle():87 if not self.is_bundle():
85 raise Exception('Not a bundle')88 raise Exception('Not a bundle')
8689
=== modified file 'tests_functional/create/test_ansible_create.py'
--- tests_functional/create/test_ansible_create.py 2014-10-22 20:02:21 +0000
+++ tests_functional/create/test_ansible_create.py 2015-08-20 13:36:17 +0000
@@ -62,14 +62,19 @@
62 'lib/charmhelpers/contrib/templating/__init__.py',62 'lib/charmhelpers/contrib/templating/__init__.py',
63 'lib/charmhelpers/contrib/templating/contexts.py',63 'lib/charmhelpers/contrib/templating/contexts.py',
64 'lib/charmhelpers/core/__init__.py',64 'lib/charmhelpers/core/__init__.py',
65 'lib/charmhelpers/core/decorators.py',
66 'lib/charmhelpers/core/files.py',
65 'lib/charmhelpers/core/fstab.py',67 'lib/charmhelpers/core/fstab.py',
66 'lib/charmhelpers/core/hookenv.py',68 'lib/charmhelpers/core/hookenv.py',
67 'lib/charmhelpers/core/host.py',69 'lib/charmhelpers/core/host.py',
70 'lib/charmhelpers/core/hugepage.py',
68 'lib/charmhelpers/core/services/__init__.py',71 'lib/charmhelpers/core/services/__init__.py',
69 'lib/charmhelpers/core/services/base.py',72 'lib/charmhelpers/core/services/base.py',
70 'lib/charmhelpers/core/services/helpers.py',73 'lib/charmhelpers/core/services/helpers.py',
74 'lib/charmhelpers/core/strutils.py',
71 'lib/charmhelpers/core/sysctl.py',75 'lib/charmhelpers/core/sysctl.py',
72 'lib/charmhelpers/core/templating.py',76 'lib/charmhelpers/core/templating.py',
77 'lib/charmhelpers/core/unitdata.py',
73 'lib/charmhelpers/fetch/__init__.py',78 'lib/charmhelpers/fetch/__init__.py',
74 'lib/charmhelpers/fetch/archiveurl.py',79 'lib/charmhelpers/fetch/archiveurl.py',
75 'lib/charmhelpers/fetch/bzrurl.py',80 'lib/charmhelpers/fetch/bzrurl.py',
7681
=== modified file 'tests_functional/create/test_python_create.py'
--- tests_functional/create/test_python_create.py 2014-10-22 20:02:21 +0000
+++ tests_functional/create/test_python_create.py 2015-08-20 13:36:17 +0000
@@ -53,14 +53,19 @@
53 dynamic_files = [53 dynamic_files = [
54 'lib/charmhelpers/__init__.py',54 'lib/charmhelpers/__init__.py',
55 'lib/charmhelpers/core/__init__.py',55 'lib/charmhelpers/core/__init__.py',
56 'lib/charmhelpers/core/decorators.py',
57 'lib/charmhelpers/core/files.py',
56 'lib/charmhelpers/core/fstab.py',58 'lib/charmhelpers/core/fstab.py',
57 'lib/charmhelpers/core/hookenv.py',59 'lib/charmhelpers/core/hookenv.py',
58 'lib/charmhelpers/core/host.py',60 'lib/charmhelpers/core/host.py',
61 'lib/charmhelpers/core/hugepage.py',
59 'lib/charmhelpers/core/services/__init__.py',62 'lib/charmhelpers/core/services/__init__.py',
60 'lib/charmhelpers/core/services/base.py',63 'lib/charmhelpers/core/services/base.py',
61 'lib/charmhelpers/core/services/helpers.py',64 'lib/charmhelpers/core/services/helpers.py',
65 'lib/charmhelpers/core/strutils.py',
62 'lib/charmhelpers/core/sysctl.py',66 'lib/charmhelpers/core/sysctl.py',
63 'lib/charmhelpers/core/templating.py',67 'lib/charmhelpers/core/templating.py',
68 'lib/charmhelpers/core/unitdata.py',
64 ]69 ]
65 return sorted(static_files + dynamic_files)70 return sorted(static_files + dynamic_files)
6671

Subscribers

People subscribed via source and target branches