Code review comment for lp:~tvansteenburgh/charm-helpers/config-wrapper

Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM +1 Thanks for adding this.

Some optional minors, prev_dict might be _prev_dict. It is private.

in changed
   call self.previous(key) rather than directly access prev_dict

use CONFIG_FILE_NAME as the default path in __init__, but allow it to be modified, that might make some of the patching in the tests go away

review: Approve

« Back to merge proposal