Code review comment for lp:~tvansteenburgh/charm-helpers/config-implicit-save

Revision history for this message
Stuart Bishop (stub) wrote :

There actually *is* a global config object, because the config() method is using the @cached decorator. This could even be made explicit.

I didn't know you could check for sys.exc_type to catch this case (I imagine you would need to ignore SystemExit?). In any case, I don't think it is a good idea here; I have hooks that catch exceptions, log nice error messages, and sys.exit(1).

« Back to merge proposal