Merge lp:~tuxator/midori/katze-net into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6281
Merged at revision: 6281
Proposed branch: lp:~tuxator/midori/katze-net
Merge into: lp:midori
Diff against target: 132 lines (+8/-52)
6 files modified
extensions/feed-panel/katze-net.c (+1/-40)
extensions/feed-panel/katze-net.h (+0/-5)
extensions/feed-panel/main.c (+1/-0)
katze/katze-item.c (+0/-2)
katze/katze.h (+6/-1)
midori/midori-view.c (+0/-4)
To merge this branch: bzr merge lp:~tuxator/midori/katze-net
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+177256@code.launchpad.net

Commit message

Move katze-net to feed-extension cause it is the last user of it

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Makes sense. And nice to see an unused code path go. Runs fine from a bit of testing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== renamed file 'katze/katze-net.c' => 'extensions/feed-panel/katze-net.c'
--- katze/katze-net.c 2013-06-17 20:27:52 +0000
+++ extensions/feed-panel/katze-net.c 2013-07-27 12:43:27 +0000
@@ -133,42 +133,6 @@
133}133}
134134
135static gboolean135static gboolean
136katze_net_local_cb (KatzeNetPriv* priv)
137{
138 KatzeNetRequest* request = priv->request;
139 gchar* filename = g_filename_from_uri (request->uri, NULL, NULL);
140
141 if (!filename || g_access (filename, F_OK) != 0)
142 {
143 request->status = KATZE_NET_NOT_FOUND;
144 if (priv->status_cb)
145 priv->status_cb (request, priv->user_data);
146 }
147 else if (!(priv->status_cb && !priv->status_cb (request, priv->user_data))
148 && priv->transfer_cb)
149 {
150 gchar* contents = NULL;
151 gsize length;
152
153 request->status = KATZE_NET_VERIFIED;
154 if (!g_file_get_contents (filename, &contents, &length, NULL))
155 {
156 request->status = KATZE_NET_FAILED;
157 }
158 else
159 {
160 request->status = KATZE_NET_DONE;
161 request->data = contents;
162 request->length = length;
163 }
164 priv->transfer_cb (request, priv->user_data);
165 }
166 g_free (filename);
167 katze_net_priv_free (priv);
168 return FALSE;
169}
170
171static gboolean
172katze_net_default_cb (KatzeNetPriv* priv)136katze_net_default_cb (KatzeNetPriv* priv)
173{137{
174 KatzeNetRequest* request;138 KatzeNetRequest* request;
@@ -244,10 +208,7 @@
244 return;208 return;
245 }209 }
246210
247 if (g_str_has_prefix (uri, "file://"))211 g_idle_add ((GSourceFunc)katze_net_default_cb, priv);
248 g_idle_add ((GSourceFunc)katze_net_local_cb, priv);
249 else
250 g_idle_add ((GSourceFunc)katze_net_default_cb, priv);
251#endif212#endif
252}213}
253214
254215
=== renamed file 'katze/katze-net.h' => 'extensions/feed-panel/katze-net.h'
--- katze/katze-net.h 2013-06-17 20:27:52 +0000
+++ extensions/feed-panel/katze-net.h 2013-07-27 12:43:27 +0000
@@ -12,11 +12,6 @@
12#ifndef __KATZE_NET_H__12#ifndef __KATZE_NET_H__
13#define __KATZE_NET_H__13#define __KATZE_NET_H__
1414
15#ifndef HAVE_WEBKIT2
16 #include <webkit/webkit.h>
17#else
18 #include <webkit2/webkit2.h>
19#endif
20#include "katze-utils.h"15#include "katze-utils.h"
2116
22G_BEGIN_DECLS17G_BEGIN_DECLS
2318
=== modified file 'extensions/feed-panel/main.c'
--- extensions/feed-panel/main.c 2013-04-20 00:59:18 +0000
+++ extensions/feed-panel/main.c 2013-07-27 12:43:27 +0000
@@ -13,6 +13,7 @@
13#include "feed-atom.h"13#include "feed-atom.h"
14#include "feed-rss.h"14#include "feed-rss.h"
1515
16#include "katze-net.h"
16#include <midori/midori.h>17#include <midori/midori.h>
1718
18#define EXTENSION_NAME "Feed Panel"19#define EXTENSION_NAME "Feed Panel"
1920
=== modified file 'katze/katze-item.c'
--- katze/katze-item.c 2013-07-16 14:20:37 +0000
+++ katze/katze-item.c 2013-07-27 12:43:27 +0000
@@ -15,8 +15,6 @@
1515
16#include <glib/gi18n.h>16#include <glib/gi18n.h>
1717
18#include "katze/katze.h"
19
20/**18/**
21 * SECTION:katze-item19 * SECTION:katze-item
22 * @short_description: A useful item20 * @short_description: A useful item
2321
=== modified file 'katze/katze.h'
--- katze/katze.h 2013-03-23 01:38:17 +0000
+++ katze/katze.h 2013-07-27 12:43:27 +0000
@@ -20,7 +20,12 @@
20#include "katze-item.h"20#include "katze-item.h"
21#include "katze-array.h"21#include "katze-array.h"
22#include "katze-arrayaction.h"22#include "katze-arrayaction.h"
23#include "katze-net.h"
24#include "katze-preferences.h"23#include "katze-preferences.h"
2524
25#ifndef HAVE_WEBKIT2
26 #include <webkit/webkit.h>
27#else
28 #include <webkit2/webkit2.h>
29#endif
30
26#endif /* __KATZE_H__ */31#endif /* __KATZE_H__ */
2732
=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2013-07-17 17:33:31 +0000
+++ midori/midori-view.c 2013-07-27 12:43:27 +0000
@@ -3143,10 +3143,6 @@
3143 view->find_links = -1;3143 view->find_links = -1;
3144 view->alerts = 0;3144 view->alerts = 0;
31453145
3146 /* Force the compiler to not optimize out katze_net_load_uri */
3147 if (!g_strcmp0 (view->icon_uri, ""))
3148 katze_net_load_uri (NULL, NULL, (KatzeNetStatusCb)NULL, (KatzeNetTransferCb)NULL, view);
3149
3150 view->item = katze_item_new ();3146 view->item = katze_item_new ();
31513147
3152 view->scrollh = view->scrollv = -2;3148 view->scrollh = view->scrollv = -2;

Subscribers

People subscribed via source and target branches

to all changes: