Merge lp:~tuxator/midori/adblock-regexp into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6223
Merged at revision: 6223
Proposed branch: lp:~tuxator/midori/adblock-regexp
Merge into: lp:midori
Diff against target: 23 lines (+7/-0)
1 file modified
extensions/adblock.c (+7/-0)
To merge this branch: bzr merge lp:~tuxator/midori/adblock-regexp
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+170700@code.launchpad.net

Commit message

Escape square brackets in adblock_fixup_regexp

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'extensions/adblock.c'
--- extensions/adblock.c 2013-03-03 21:02:11 +0000
+++ extensions/adblock.c 2013-06-20 20:56:24 +0000
@@ -1156,6 +1156,12 @@
1156 case '^':1156 case '^':
1157 case '+':1157 case '+':
1158 break;1158 break;
1159 case '[':
1160 g_string_append (str, "\\[");
1161 break;
1162 case ']':
1163 g_string_append (str, "\\]");
1164 break;
1159 default:1165 default:
1160 g_string_append_printf (str,"%c", *src);1166 g_string_append_printf (str,"%c", *src);
1161 break;1167 break;
@@ -1781,6 +1787,7 @@
17811787
1782 g_assert_cmpstr (adblock_parse_line (".*foo/bar"), ==, "..*foo/bar");1788 g_assert_cmpstr (adblock_parse_line (".*foo/bar"), ==, "..*foo/bar");
1783 g_assert_cmpstr (adblock_parse_line ("http://bla.blub/*"), ==, "http://bla.blub/");1789 g_assert_cmpstr (adblock_parse_line ("http://bla.blub/*"), ==, "http://bla.blub/");
1790 g_assert_cmpstr (adblock_parse_line ("bag?r[]=*cpa"), ==, "bag\\?r\\[\\]=.*cpa");
1784 adblock_destroy_db ();1791 adblock_destroy_db ();
1785}1792}
17861793

Subscribers

People subscribed via source and target branches

to all changes: