Merge lp:~tuxator/midori/adblock-parentheses into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6282
Merged at revision: 6284
Proposed branch: lp:~tuxator/midori/adblock-parentheses
Merge into: lp:midori
Diff against target: 23 lines (+7/-0)
1 file modified
extensions/adblock.c (+7/-0)
To merge this branch: bzr merge lp:~tuxator/midori/adblock-parentheses
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+177257@code.launchpad.net

Commit message

Escape parentheses in adblock_fixup_regexp

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

The change looks legit. The indentation of the case/ default statements is off, please correct that.

review: Needs Fixing
6282. By Paweł Forysiuk

Fix indentation

Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'extensions/adblock.c'
--- extensions/adblock.c 2013-06-22 16:01:42 +0000
+++ extensions/adblock.c 2013-07-28 20:21:26 +0000
@@ -1153,6 +1153,12 @@
1153 case ']':1153 case ']':
1154 g_string_append (str, "\\]");1154 g_string_append (str, "\\]");
1155 break;1155 break;
1156 case '(':
1157 g_string_append (str, "\\(");
1158 break;
1159 case ')':
1160 g_string_append (str, "\\)");
1161 break;
1156 default:1162 default:
1157 g_string_append_printf (str,"%c", *src);1163 g_string_append_printf (str,"%c", *src);
1158 break;1164 break;
@@ -1779,6 +1785,7 @@
1779 g_assert_cmpstr (adblock_parse_line (".*foo/bar"), ==, "..*foo/bar");1785 g_assert_cmpstr (adblock_parse_line (".*foo/bar"), ==, "..*foo/bar");
1780 g_assert_cmpstr (adblock_parse_line ("http://bla.blub/*"), ==, "http://bla.blub/");1786 g_assert_cmpstr (adblock_parse_line ("http://bla.blub/*"), ==, "http://bla.blub/");
1781 g_assert_cmpstr (adblock_parse_line ("bag?r[]=*cpa"), ==, "bag\\?r\\[\\]=.*cpa");1787 g_assert_cmpstr (adblock_parse_line ("bag?r[]=*cpa"), ==, "bag\\?r\\[\\]=.*cpa");
1788 g_assert_cmpstr (adblock_parse_line ("(facebookLike,"), ==, "\\(facebookLike,");
1782 adblock_destroy_db ();1789 adblock_destroy_db ();
1783}1790}
17841791

Subscribers

People subscribed via source and target branches

to all changes: