Code review comment for lp:~tusharbehera/linaro-image-tools/origen-generic

Revision history for this message
Milo Casagrande (milo) wrote :

Hello Tushar,

overall it looks good to me. I tested creating a panda image and everything works as expected.
If somebody else can take a look and perform another image creation/installation, that would be better.

One thing that should also be done is documenting the two new fields (samsung_env_start, samsung_bl2_start) here:

In order to have all the fields listed and to keep track of them (also for people creating new hwpack configuration files).

review: Approve

« Back to merge proposal