Code review comment for lp:~turan-mahmudov-l/ubuntu-keyboard/trunk

Hi.

I made changes. But I didn't understand this: "Also, I see that you've
added the Arabic dictionary (hunspell-ar) as a dependency, was that
intentional (if so we'll need to make some further changes to make it
usable by the plugin) or just accidentally copied from the Arabic plugin
entry?" - what I should do?

"bzr merge lp:ubuntu-trunk" says "bzr: ERROR: Not a branch: "bzr+ssh://
bazaar.launchpad.net/+branch/ubuntu-trunk/".

I pushed files to "~turan-mahmudov-l/ubuntu-azerbaijani-keyboard/trunk/".

On Thu, Oct 30, 2014 at 3:43 PM, Michael Sheldon <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> Hi, just a couple more changes needed:
>
> To let the rest of the keyboard system know about your plugin there are a
> couple of files you'll need to make some small changes to. You'll need to
> add an entry for Azerbaijani in the languageIdToName function in
> qml/keys/LanguageMenu.qml and in the freeTextLanguageKeyboard and
> languageIsSupported functions in qml/KeyboardContainer.qml and
> WordEngine::onLanguageChanged in src/lib/logic/wordengine.cpp (these should
> really be redesigned to avoid the need for that, but that's currently
> fairly low on the priority list I'm afraid).
>
> Also, I see that you've added the Arabic dictionary (hunspell-ar) as a
> dependency, was that intentional (if so we'll need to make some further
> changes to make it usable by the plugin) or just accidentally copied from
> the Arabic plugin entry?
>
> Finally, it'd be handy if you could update your branch from trunk to make
> sure everything merges smoothly when we land this. To do that simply run
> 'bzr merge lp:ubuntu-trunk', if there are any merge conflicts let me know
> and I'll help you correct them, otherwise just run 'bzr commit -m "Merge
> from trunk"' and 'bzr push'.
>
> Thanks!
> Mike.
> --
>
> https://code.launchpad.net/~turan-mahmudov-l/ubuntu-keyboard/trunk/+merge/236139
> You are the owner of lp:~turan-mahmudov-l/ubuntu-keyboard/trunk.
>

--
Hörmətlə,
Turan Mahmudov
E-mail: <email address hidden>
www.turanmahmudov.net