Code review comment for lp:~turan-mahmudov-l/ubuntu-keyboard/trunk

Revision history for this message
Turan Mahmudov (turan-mahmudov-l) wrote :

Hi Michael, I updated and pushed to
https://launchpad.net/ubuntu-azerbaijani-keyboard
I can't merge this to ubuntu-keyboard

On Fri, Oct 24, 2014 at 7:51 PM, Michael Sheldon <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> Hi Turan,
>
> Sorry for the delay on re-reviewing this, we've been frantically
> sprinting all week :). It looks like there are a couple of small problems
> with the packaging. You'll need to add an entry in the debian/control file
> to tell it about your new plugin, something like:
>
> Package: ubuntu-keyboard-azerbaijani
> Architecture: any
> Depends: ubuntu-keyboard (= ${binary:Version}),
> ${misc:Depends},
> ${shlibs:Depends},
> Description: Ubuntu on-screen keyboard data files - Azerbaijani
> Data files for the Ubuntu virtual keyboard - Azerbaijani
>
> This should be added after the entry for the ubuntu-keyboard-arabic
> package (we list the language plugins alphabetically).
>
> You'll also need to include an install file for the new Debian package
> (this tells the package build process which files to include), this can
> simply be a file in the debian/ directory called
> ubuntu-keyboard-azerbaijani.install with the line:
>
> usr/share/maliit/plugins/com/ubuntu/lib/az/
>
> (Note that there isn't a slash at the beginning of the line).
>
> If this causes any issues just let me know and I'll happily walk you
> through the process :)
>
> Thanks!
> Mike.
>
> --
>
> https://code.launchpad.net/~turan-mahmudov-l/ubuntu-keyboard/trunk/+merge/236139
> You are the owner of lp:~turan-mahmudov-l/ubuntu-keyboard/trunk.
>

--
Hörmətlə,
Turan Mahmudov
E-mail: <email address hidden>
www.turanmahmudov.net

« Back to merge proposal