Merge lp:~ttosttos/switchboard/fix-989076 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by ttosttos
Status: Merged
Merged at revision: 210
Proposed branch: lp:~ttosttos/switchboard/fix-989076
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 183 lines (+21/-62)
4 files modified
Switchboard/switchboard-app.vala (+7/-7)
Switchboard/switchboard-categoryview.vala (+2/-2)
cmake/Translations.cmake (+3/-3)
po/switchboard.pot (+9/-50)
To merge this branch: bzr merge lp:~ttosttos/switchboard/fix-989076
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+108673@code.launchpad.net

Description of the change

- uses the most recent Translations.cmake so all translatable strings get pulled into template by xgettext
- made logging messages non-translatable. They were being incorrectly marked for translation.
- Updated template (switchboard.pot)

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Switchboard/switchboard-app.vala'
--- Switchboard/switchboard-app.vala 2012-03-27 10:51:17 +0000
+++ Switchboard/switchboard-app.vala 2012-06-05 05:38:18 +0000
@@ -141,7 +141,7 @@
141 if (current_plug["title"] != title) {141 if (current_plug["title"] != title) {
142 try {142 try {
143 // The plug is already selected143 // The plug is already selected
144 debug(_("Exiting plug \"%s\" from Switchboard controller.."), current_plug["title"]);144 debug("Exiting plug \"%s\" from Switchboard controller..", current_plug["title"]);
145 plug_closed();145 plug_closed();
146 var cmd_exploded = executable.split(" ");146 var cmd_exploded = executable.split(" ");
147 string working_directory = File.new_for_path(cmd_exploded[0]).get_parent().get_path();147 string working_directory = File.new_for_path(cmd_exploded[0]).get_parent().get_path();
@@ -153,7 +153,7 @@
153 navigation_button.stock_id = Gtk.Stock.HOME;153 navigation_button.stock_id = Gtk.Stock.HOME;
154 switch_to_socket ();154 switch_to_socket ();
155 } catch {155 } catch {
156 warning(_("Failed to launch plug: title %s | executable %s"), title, executable);156 warning("Failed to launch plug: title %s | executable %s", title, executable);
157 }157 }
158 }158 }
159 else {159 else {
@@ -294,7 +294,7 @@
294 }294 }
295 catch295 catch
296 {296 {
297 warning(_(@"Unable to iterate over enumerated plug directory \"$path\"'s contents"));297 warning(@"Unable to iterate over enumerated plug directory \"$path\"'s contents");
298 }298 }
299 return keyfiles;299 return keyfiles;
300 }300 }
@@ -444,16 +444,16 @@
444 var logger = new Granite.Services.Logger ();444 var logger = new Granite.Services.Logger ();
445 logger.initialize(APP_TITLE);445 logger.initialize(APP_TITLE);
446 logger.DisplayLevel = Granite.Services.LogLevel.INFO;446 logger.DisplayLevel = Granite.Services.LogLevel.INFO;
447 message(_(@"Welcome to $APP_TITLE"));447 message(@"Welcome to $APP_TITLE");
448 message(_(@"Version: $VERSION"));448 message(@"Version: $VERSION");
449 message(_("Report any issues/bugs you mind find to lp:switchboard"));449 message("Report any issues/bugs you mind find to lp:switchboard");
450450
451 Gtk.init (ref args);451 Gtk.init (ref args);
452 Bus.own_name (BusType.SESSION, "org.elementary.switchboard",452 Bus.own_name (BusType.SESSION, "org.elementary.switchboard",
453 BusNameOwnerFlags.NONE,453 BusNameOwnerFlags.NONE,
454 (conn) => {on_bus_aquired (conn, args);},454 (conn) => {on_bus_aquired (conn, args);},
455 () => {},455 () => {},
456 () => {logger.notification(_("Switchboard already running. Exiting..")); Process.exit(1);});456 () => {logger.notification("Switchboard already running. Exiting.."); Process.exit(1);});
457457
458 Gtk.main ();458 Gtk.main ();
459 return 0;459 return 0;
460460
=== modified file 'Switchboard/switchboard-categoryview.vala'
--- Switchboard/switchboard-categoryview.vala 2012-01-30 16:20:38 +0000
+++ Switchboard/switchboard-categoryview.vala 2012-06-05 05:38:18 +0000
@@ -65,14 +65,14 @@
65 Gtk.TreeIter root;65 Gtk.TreeIter root;
66 string plug_down = plug["category"].down();66 string plug_down = plug["category"].down();
67 if (!(plug_down in category_ids)) {67 if (!(plug_down in category_ids)) {
68 warning(_("Keyfile \"%s\" contains an invalid category: \"%s\", and will not be added"), plug["title"], plug["category"]);68 warning("Keyfile \"%s\" contains an invalid category: \"%s\", and will not be added", plug["title"], plug["category"]);
69 }69 }
70 category_store[plug_down].append(out root);70 category_store[plug_down].append(out root);
71 try {71 try {
72 var icon_pixbuf = theme.load_icon (plug["icon"], 48, Gtk.IconLookupFlags.GENERIC_FALLBACK);72 var icon_pixbuf = theme.load_icon (plug["icon"], 48, Gtk.IconLookupFlags.GENERIC_FALLBACK);
73 category_store[plug_down].set(root, 1, icon_pixbuf);73 category_store[plug_down].set(root, 1, icon_pixbuf);
74 } catch {74 } catch {
75 warning(_("Unable to load plug %'s icon: %s"), plug["title"], plug["icon"]);75 warning("Unable to load plug %'s icon: %s", plug["title"], plug["icon"]);
76 }76 }
77 category_store[plug_down].set(root, 0, plug["title"]);77 category_store[plug_down].set(root, 0, plug["title"]);
78 category_store[plug_down].set(root, 2, plug["exec"]);78 category_store[plug_down].set(root, 2, plug["exec"]);
7979
=== modified file 'cmake/Translations.cmake'
--- cmake/Translations.cmake 2012-01-13 17:02:58 +0000
+++ cmake/Translations.cmake 2012-06-05 05:38:18 +0000
@@ -24,11 +24,11 @@
24 set(C_SOURCE "")24 set(C_SOURCE "")
2525
26 foreach(FILES_INPUT ${ARGN})26 foreach(FILES_INPUT ${ARGN})
27 file (GLOB SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.c)27 file (GLOB_RECURSE SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.c)
28 foreach(C_FILE ${SOURCE_FILES})28 foreach(C_FILE ${SOURCE_FILES})
29 set(C_SOURCE ${C_SOURCE} ${C_FILE})29 set(C_SOURCE ${C_SOURCE} ${C_FILE})
30 endforeach()30 endforeach()
31 file (GLOB SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.vala)31 file (GLOB_RECURSE SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.vala)
32 foreach(C_FILE ${SOURCE_FILES})32 foreach(C_FILE ${SOURCE_FILES})
33 set(C_SOURCE ${C_SOURCE} ${C_FILE})33 set(C_SOURCE ${C_SOURCE} ${C_FILE})
34 endforeach()34 endforeach()
@@ -36,6 +36,6 @@
3636
37 add_custom_command (TARGET pot COMMAND37 add_custom_command (TARGET pot COMMAND
38 ${XGETTEXT_EXECUTABLE} -d ${NLS_PACKAGE} -o ${CMAKE_CURRENT_SOURCE_DIR}/${NLS_PACKAGE}.pot38 ${XGETTEXT_EXECUTABLE} -d ${NLS_PACKAGE} -o ${CMAKE_CURRENT_SOURCE_DIR}/${NLS_PACKAGE}.pot
39 ${VALA_SOURCE} ${C_SOURCE} --keyword="_" --from-code=UTF-839 ${VALA_SOURCE} ${C_SOURCE} --keyword="_" --keyword="N_" --from-code=UTF-8
40 )40 )
41endmacro()41endmacro()
4242
=== modified file 'po/switchboard.pot'
--- po/switchboard.pot 2012-01-13 17:02:58 +0000
+++ po/switchboard.pot 2012-06-05 05:38:18 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: PACKAGE VERSION\n"9"Project-Id-Version: PACKAGE VERSION\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2012-01-13 18:01+0100\n"11"POT-Creation-Date: 2012-06-04 22:26-0700\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -17,63 +17,22 @@
17"Content-Type: text/plain; charset=CHARSET\n"17"Content-Type: text/plain; charset=CHARSET\n"
18"Content-Transfer-Encoding: 8bit\n"18"Content-Transfer-Encoding: 8bit\n"
1919
20#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:11420#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-app.vala:387
21#, c-format21msgid "Search Plugs"
22msgid "Exiting plug \"%s\" from Switchboard controller.."22msgstr ""
23msgstr ""23
2424#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
25#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:131
26#, c-format
27msgid "Failed to launch plug: title %s | executable %s"
28msgstr ""
29
30#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:263
31msgid "Unable to iterate over enumerated plug directory \"$path\"'s contents"
32msgstr ""
33
34#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:351
35msgid "Type to search ..."
36msgstr ""
37
38#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:390
39msgid "Welcome to $APP_TITLE"
40msgstr ""
41
42#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:391
43msgid "Version: $VERSION"
44msgstr ""
45
46#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:392
47msgid "Report any issues/bugs you mind find to lp:switchboard"
48msgstr ""
49
50#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:399
51msgid "Switchboard already running. Exiting.."
52msgstr ""
53
54#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:31
55msgid "Personal"25msgid "Personal"
56msgstr ""26msgstr ""
5727
58#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:3228#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
59msgid "Hardware"29msgid "Hardware"
60msgstr ""30msgstr ""
6131
62#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:3332#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
63msgid "Network and Wireless"33msgid "Network and Wireless"
64msgstr ""34msgstr ""
6535
66#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:3436#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
67msgid "System"37msgid "System"
68msgstr ""38msgstr ""
69
70#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:68
71#, c-format
72msgid ""
73"Keyfile \"%s\" contains an invalid category: \"%s\", and will not be added"
74msgstr ""
75
76#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:75
77#, c-format
78msgid "Unable to load plug %'s icon: %s"
79msgstr ""

Subscribers

People subscribed via source and target branches

to all changes: