Merge lp:~ttosttos/switchboard/fix-989076 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by ttosttos
Status: Merged
Merged at revision: 210
Proposed branch: lp:~ttosttos/switchboard/fix-989076
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 183 lines (+21/-62)
4 files modified
Switchboard/switchboard-app.vala (+7/-7)
Switchboard/switchboard-categoryview.vala (+2/-2)
cmake/Translations.cmake (+3/-3)
po/switchboard.pot (+9/-50)
To merge this branch: bzr merge lp:~ttosttos/switchboard/fix-989076
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+108673@code.launchpad.net

Description of the change

- uses the most recent Translations.cmake so all translatable strings get pulled into template by xgettext
- made logging messages non-translatable. They were being incorrectly marked for translation.
- Updated template (switchboard.pot)

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-03-27 10:51:17 +0000
3+++ Switchboard/switchboard-app.vala 2012-06-05 05:38:18 +0000
4@@ -141,7 +141,7 @@
5 if (current_plug["title"] != title) {
6 try {
7 // The plug is already selected
8- debug(_("Exiting plug \"%s\" from Switchboard controller.."), current_plug["title"]);
9+ debug("Exiting plug \"%s\" from Switchboard controller..", current_plug["title"]);
10 plug_closed();
11 var cmd_exploded = executable.split(" ");
12 string working_directory = File.new_for_path(cmd_exploded[0]).get_parent().get_path();
13@@ -153,7 +153,7 @@
14 navigation_button.stock_id = Gtk.Stock.HOME;
15 switch_to_socket ();
16 } catch {
17- warning(_("Failed to launch plug: title %s | executable %s"), title, executable);
18+ warning("Failed to launch plug: title %s | executable %s", title, executable);
19 }
20 }
21 else {
22@@ -294,7 +294,7 @@
23 }
24 catch
25 {
26- warning(_(@"Unable to iterate over enumerated plug directory \"$path\"'s contents"));
27+ warning(@"Unable to iterate over enumerated plug directory \"$path\"'s contents");
28 }
29 return keyfiles;
30 }
31@@ -444,16 +444,16 @@
32 var logger = new Granite.Services.Logger ();
33 logger.initialize(APP_TITLE);
34 logger.DisplayLevel = Granite.Services.LogLevel.INFO;
35- message(_(@"Welcome to $APP_TITLE"));
36- message(_(@"Version: $VERSION"));
37- message(_("Report any issues/bugs you mind find to lp:switchboard"));
38+ message(@"Welcome to $APP_TITLE");
39+ message(@"Version: $VERSION");
40+ message("Report any issues/bugs you mind find to lp:switchboard");
41
42 Gtk.init (ref args);
43 Bus.own_name (BusType.SESSION, "org.elementary.switchboard",
44 BusNameOwnerFlags.NONE,
45 (conn) => {on_bus_aquired (conn, args);},
46 () => {},
47- () => {logger.notification(_("Switchboard already running. Exiting..")); Process.exit(1);});
48+ () => {logger.notification("Switchboard already running. Exiting.."); Process.exit(1);});
49
50 Gtk.main ();
51 return 0;
52
53=== modified file 'Switchboard/switchboard-categoryview.vala'
54--- Switchboard/switchboard-categoryview.vala 2012-01-30 16:20:38 +0000
55+++ Switchboard/switchboard-categoryview.vala 2012-06-05 05:38:18 +0000
56@@ -65,14 +65,14 @@
57 Gtk.TreeIter root;
58 string plug_down = plug["category"].down();
59 if (!(plug_down in category_ids)) {
60- warning(_("Keyfile \"%s\" contains an invalid category: \"%s\", and will not be added"), plug["title"], plug["category"]);
61+ warning("Keyfile \"%s\" contains an invalid category: \"%s\", and will not be added", plug["title"], plug["category"]);
62 }
63 category_store[plug_down].append(out root);
64 try {
65 var icon_pixbuf = theme.load_icon (plug["icon"], 48, Gtk.IconLookupFlags.GENERIC_FALLBACK);
66 category_store[plug_down].set(root, 1, icon_pixbuf);
67 } catch {
68- warning(_("Unable to load plug %'s icon: %s"), plug["title"], plug["icon"]);
69+ warning("Unable to load plug %'s icon: %s", plug["title"], plug["icon"]);
70 }
71 category_store[plug_down].set(root, 0, plug["title"]);
72 category_store[plug_down].set(root, 2, plug["exec"]);
73
74=== modified file 'cmake/Translations.cmake'
75--- cmake/Translations.cmake 2012-01-13 17:02:58 +0000
76+++ cmake/Translations.cmake 2012-06-05 05:38:18 +0000
77@@ -24,11 +24,11 @@
78 set(C_SOURCE "")
79
80 foreach(FILES_INPUT ${ARGN})
81- file (GLOB SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.c)
82+ file (GLOB_RECURSE SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.c)
83 foreach(C_FILE ${SOURCE_FILES})
84 set(C_SOURCE ${C_SOURCE} ${C_FILE})
85 endforeach()
86- file (GLOB SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.vala)
87+ file (GLOB_RECURSE SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.vala)
88 foreach(C_FILE ${SOURCE_FILES})
89 set(C_SOURCE ${C_SOURCE} ${C_FILE})
90 endforeach()
91@@ -36,6 +36,6 @@
92
93 add_custom_command (TARGET pot COMMAND
94 ${XGETTEXT_EXECUTABLE} -d ${NLS_PACKAGE} -o ${CMAKE_CURRENT_SOURCE_DIR}/${NLS_PACKAGE}.pot
95- ${VALA_SOURCE} ${C_SOURCE} --keyword="_" --from-code=UTF-8
96+ ${VALA_SOURCE} ${C_SOURCE} --keyword="_" --keyword="N_" --from-code=UTF-8
97 )
98 endmacro()
99
100=== modified file 'po/switchboard.pot'
101--- po/switchboard.pot 2012-01-13 17:02:58 +0000
102+++ po/switchboard.pot 2012-06-05 05:38:18 +0000
103@@ -8,7 +8,7 @@
104 msgstr ""
105 "Project-Id-Version: PACKAGE VERSION\n"
106 "Report-Msgid-Bugs-To: \n"
107-"POT-Creation-Date: 2012-01-13 18:01+0100\n"
108+"POT-Creation-Date: 2012-06-04 22:26-0700\n"
109 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
110 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
111 "Language-Team: LANGUAGE <LL@li.org>\n"
112@@ -17,63 +17,22 @@
113 "Content-Type: text/plain; charset=CHARSET\n"
114 "Content-Transfer-Encoding: 8bit\n"
115
116-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:114
117-#, c-format
118-msgid "Exiting plug \"%s\" from Switchboard controller.."
119-msgstr ""
120-
121-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:131
122-#, c-format
123-msgid "Failed to launch plug: title %s | executable %s"
124-msgstr ""
125-
126-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:263
127-msgid "Unable to iterate over enumerated plug directory \"$path\"'s contents"
128-msgstr ""
129-
130-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:351
131-msgid "Type to search ..."
132-msgstr ""
133-
134-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:390
135-msgid "Welcome to $APP_TITLE"
136-msgstr ""
137-
138-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:391
139-msgid "Version: $VERSION"
140-msgstr ""
141-
142-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:392
143-msgid "Report any issues/bugs you mind find to lp:switchboard"
144-msgstr ""
145-
146-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-app.vala:399
147-msgid "Switchboard already running. Exiting.."
148-msgstr ""
149-
150-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:31
151+#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-app.vala:387
152+msgid "Search Plugs"
153+msgstr ""
154+
155+#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
156 msgid "Personal"
157 msgstr ""
158
159-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:32
160+#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
161 msgid "Hardware"
162 msgstr ""
163
164-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:33
165+#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
166 msgid "Network and Wireless"
167 msgstr ""
168
169-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:34
170+#: /home/ttosttos/Projects/elementary/Bugs/switchboard-fix-989076/po/../Switchboard//switchboard-categoryview.vala:29
171 msgid "System"
172 msgstr ""
173-
174-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:68
175-#, c-format
176-msgid ""
177-"Keyfile \"%s\" contains an invalid category: \"%s\", and will not be added"
178-msgstr ""
179-
180-#: /home/xapantu/Dev/switchboard/trunk/po/../Switchboard//switchboard-categoryview.vala:75
181-#, c-format
182-msgid "Unable to load plug %'s icon: %s"
183-msgstr ""

Subscribers

People subscribed via source and target branches

to all changes: