Merge lp:~ttosttos/granite/fix-871831 into lp:~elementary-pantheon/granite/granite

Proposed by ttosttos
Status: Merged
Merged at revision: 236
Proposed branch: lp:~ttosttos/granite/fix-871831
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 57 lines (+6/-6)
2 files modified
lib/GtkPatch/AboutDialog.vala (+4/-4)
lib/Widgets/AboutDialog.vala (+2/-2)
To merge this branch: bzr merge lp:~ttosttos/granite/fix-871831
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+105448@code.launchpad.net

Description of the change

Makes strings in About dialog translatable

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/GtkPatch/AboutDialog.vala'
--- lib/GtkPatch/AboutDialog.vala 2012-04-26 21:38:04 +0000
+++ lib/GtkPatch/AboutDialog.vala 2012-05-11 07:42:18 +0000
@@ -37,7 +37,7 @@
37 artists_label.set_text("");37 artists_label.set_text("");
38 }38 }
39 else {39 else {
40 artists_label.set_markup(set_string_from_string_array("<span size=\"small\">Designed by" + ":</span>\n", _artists));40 artists_label.set_markup(set_string_from_string_array("<span size=\"small\">" + _("Designed by") + ":</span>\n", _artists));
41 artists_label.show();41 artists_label.show();
42 }42 }
43 }43 }
@@ -56,7 +56,7 @@
56 authors_label.set_text("");56 authors_label.set_text("");
57 }57 }
58 else {58 else {
59 authors_label.set_markup(set_string_from_string_array("<span size=\"small\">Written by" + ":</span>\n", _authors));59 authors_label.set_markup(set_string_from_string_array("<span size=\"small\">" + _("Written by") + ":</span>\n", _authors));
60 authors_label.show();60 authors_label.show();
61 }61 }
62 }62 }
@@ -172,7 +172,7 @@
172 translators_label.set_text("");172 translators_label.set_text("");
173 }173 }
174 else {174 else {
175 translators_label.set_markup("<span size=\"small\">Translated by " + _translator_credits.replace("&", "&amp;") + "</span>\n");175 translators_label.set_markup("<span size=\"small\">" + _("Translated by ") + _translator_credits.replace("&", "&amp;") + "</span>\n");
176 translators_label.show();176 translators_label.show();
177 }177 }
178 }178 }
@@ -441,7 +441,7 @@
441441
442 private void set_generic_license(string url, string license_type)442 private void set_generic_license(string url, string license_type)
443 {443 {
444 license_label.set_markup("<span size=\"small\">This program is published under the terms of the " + license_type + " license, it comes with ABSOLUTELY NO WARRANTY; for details, visit <a href=\"" + url + "\">" + url + "</a></span>\n");444 license_label.set_markup("<span size=\"small\">" + _("This program is published under the terms of the ") + license_type + _(" license, it comes with ABSOLUTELY NO WARRANTY; for details, visit ") + "<a href=\"" + url + "\">" + url + "</a></span>\n");
445 license_label.show();445 license_label.show();
446 }446 }
447447
448448
=== modified file 'lib/Widgets/AboutDialog.vala'
--- lib/Widgets/AboutDialog.vala 2012-04-27 13:26:24 +0000
+++ lib/Widgets/AboutDialog.vala 2012-05-11 07:42:18 +0000
@@ -144,12 +144,12 @@
144 ((Gtk.ButtonBox) action_area).set_child_non_homogeneous (help_button, true);144 ((Gtk.ButtonBox) action_area).set_child_non_homogeneous (help_button, true);
145145
146 /* translate button */146 /* translate button */
147 translate_button = new Button.with_label("Translate this app");147 translate_button = new Button.with_label(_("Translate this app"));
148 translate_button.pressed.connect ( () => { activate_link(translate); });148 translate_button.pressed.connect ( () => { activate_link(translate); });
149 action_area.pack_start (translate_button, false, false, 0);149 action_area.pack_start (translate_button, false, false, 0);
150150
151 /* bug button */151 /* bug button */
152 bug_button = new Button.with_label ("Report a problem");152 bug_button = new Button.with_label (_("Report a problem"));
153 bug_button.pressed.connect (() => { activate_link(bug); });153 bug_button.pressed.connect (() => { activate_link(bug); });
154 action_area.pack_start (bug_button, false, false, 0);154 action_area.pack_start (bug_button, false, false, 0);
155155

Subscribers

People subscribed via source and target branches