Code review comment for lp:~tsy/openobject-addons/l10n_syscohada

Revision history for this message
qdp (OpenERP) (qdp) wrote :

Hi Tidiane Sy (BAAMTU),

i've checked and i can see that you did really a good job.

The only very small thing that may need to be fixed is the internal type of the account "521100 Banque X" that should be a view account. Indeed, the wizard will create children accounts for it (for deposit, current...), and we think that it's a best practice to allow having children only for account of type view, otherwise it may mess the computation, analyses and what so forth.

So for this reason, there is a constraint currently in the accounts that forbid such a configuration, and you should change accordingly to it, otherwise it will raise as soon as you try to modify and save this account.

Thanks for your contribution, again. Let us know as soon as you made this modification in your branch.

Quentin.

review: Needs Fixing

« Back to merge proposal