Code review comment for ~tsimonq2/ssh-import-id/+git/add-team-support:master

Revision history for this message
Scott Moser (smoser) wrote :

@Simon,

I poked a bit here is a diff from master that I think seems a reasonable start.
 http://paste.ubuntu.com/p/jcC53Sp3KJ/

Basically, if the +ssh-keys path failed *and* the url was the default url to launchpad ssh keys, then we will go in looking to see if it is a team also.

The fetch_keys_lp_team can be a normal python function that raises exception on error.
We're hoping to get away from things like 'die' in function calls.

Does that seem a reasonable direction to you?

There are plenty of improvements to be made. I can see that we may well want this to return a tuple of "path" and "keys", where "path" is:
  group1/sub-group2/user
So that the code in import_keys could be adjusted to more clearly indicate how this key got there.

Thoughts?

« Back to merge proposal