Code review comment for ~tsimonq2/ssh-import-id/+git/add-team-support:master

Revision history for this message
Colin Watson (cjwatson) wrote :

Here's the reason that won't work:

    account_status = exported(
        Choice(
            title=_("The status of this person's account"), required=True,
            readonly=True, vocabulary=AccountStatus),
        as_of='devel')

I understand your concerns, and they do align with why Launchpad originally tried to produce stable API versions. On the other hand, in practice, all the interfaces being used here are in fact extremely stable and I have a hard time imagining us changing them; we would certainly attempt to get an idea of whether they were being used in production first, and at that point we'd discover the uses by ssh-import-id. I wouldn't expect this to break.

You make a reasonable argument for avoiding launchpadlib in this particular case. I think it would be OK to start from https://api.launchpad.net/devel/~TEAM/members.

« Back to merge proposal