Merge ~tsimonq2/autopkgtest-cloud/+git/bug-1654761:disallow-duplicate-tests into autopkgtest-cloud:master
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Brian Murray | ||||
Proposed branch: | ~tsimonq2/autopkgtest-cloud/+git/bug-1654761:disallow-duplicate-tests | ||||
Merge into: | autopkgtest-cloud:master | ||||
Diff against target: |
100 lines (+70/-0) 2 files modified
webcontrol/request/inprogress.py (+62/-0) webcontrol/request/submit.py (+8/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brian Murray | Needs Fixing | ||
Łukasz Zemczak | Needs Fixing | ||
Steve Langasek | Needs Information | ||
Iain Lane | Pending | ||
Review via email: mp+363643@code.launchpad.net |
Description of the change
This is an IN PROGRESS merge request. I would like a review before I proceed further to make sure I'm on the right track.
This change fixes bug 1654761 and supersedes https:/
Left to do:
- Write tests.
- Implement support for reading the AMQP queue.
From the research that I have done, reading from the AMQP queue will have to be done by:
- Declaring the queue with no autoacks.
- Read the contents of the queue.
- Disconnect without ACKing.
However, I am not entirely sure this is the correct line of action here. From reading through the code, there seems to be a queues.json file I could use. If that is the case, I would need an example file when it has some content to base my code off of. Any advice is appreciated here.
I tested this code by running the following (using the pastebin Iain linked in the last MP):
from inprogress import InProgress
inprogress = InProgress()
inprogress.
does this take care to exclude requester name from the data being compared?