Merge lp:~tsarev/percona-server/5.1_fix_bug_860416 into lp:percona-server/5.1

Proposed by Oleg Tsarev
Status: Superseded
Proposed branch: lp:~tsarev/percona-server/5.1_fix_bug_860416
Merge into: lp:percona-server/5.1
Diff against target: 174 lines (+93/-19)
4 files modified
patches/innodb_bug47167_test_fix.patch (+0/-8)
patches/innodb_swap_builtin_plugin.patch (+11/-0)
patches/mysql-test.diff (+4/-2)
patches/slow_extended.patch (+78/-9)
To merge this branch: bzr merge lp:~tsarev/percona-server/5.1_fix_bug_860416
Reviewer Review Type Date Requested Status
Percona developers Pending
Review via email: mp+77214@code.launchpad.net

This proposal has been superseded by a proposal from 2011-10-08.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'patches/innodb_bug47167_test_fix.patch'
2--- patches/innodb_bug47167_test_fix.patch 2011-08-01 17:56:34 +0000
3+++ patches/innodb_bug47167_test_fix.patch 2011-10-08 01:59:25 +0000
4@@ -42,11 +42,3 @@
5
6 # Following are negative tests, all should fail.
7 --disable_warnings
8---- a/mysql-test/include/have_innodb.inc
9-+++ b/mysql-test/include/have_innodb.inc
10-@@ -1,4 +1,4 @@
11--if (`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.ENGINES WHERE engine = 'innodb' AND support IN ('YES', 'DEFAULT', 'ENABLED')`)
12-+if (`select count(*)>0 from information_schema.plugins where plugin_name like 'xtradb%'`)
13- {
14- --skip Test requires InnoDB.
15- }
16
17=== modified file 'patches/innodb_swap_builtin_plugin.patch'
18--- patches/innodb_swap_builtin_plugin.patch 2011-08-09 13:35:34 +0000
19+++ patches/innodb_swap_builtin_plugin.patch 2011-10-08 01:59:25 +0000
20@@ -198,3 +198,14 @@
21 MYSQL_PLUGIN_DYNAMIC(innodb_plugin, [ha_innodb_plugin.la])
22 MYSQL_PLUGIN_ACTIONS(innodb_plugin, [
23 AC_CHECK_HEADERS(sched.h)
24+--- a/mysql-test/mysql-test-run.pl
25++++ b/mysql-test/mysql-test-run.pl
26+@@ -157,7 +157,7 @@
27+ # executables will be used by the test suite.
28+ our $opt_vs_config = $ENV{'MTR_VS_CONFIG'};
29+
30+-my $DEFAULT_SUITES= "main,binlog,federated,rpl,rpl_ndb,ndb,innodb,innodb_plugin";
31++my $DEFAULT_SUITES= "main,binlog,federated,rpl,rpl_ndb,ndb,innodb_plugin";
32+ my $opt_suites;
33+
34+ our $opt_verbose= 0; # Verbose output, enable with --verbose
35
36=== modified file 'patches/mysql-test.diff'
37--- patches/mysql-test.diff 2011-10-05 00:02:14 +0000
38+++ patches/mysql-test.diff 2011-10-08 01:59:25 +0000
39@@ -4009,7 +4009,7 @@
40 +0
41 --- /dev/null
42 +++ b/mysql-test/r/percona_server_variables_debug.result
43-@@ -0,0 +1,347 @@
44+@@ -0,0 +1,349 @@
45 +SELECT Variable_name FROM INFORMATION_SCHEMA.SESSION_VARIABLES ORDER BY 1;
46 +Variable_name
47 +AUTOCOMMIT
48@@ -4194,6 +4194,7 @@
49 +LOG_OUTPUT
50 +LOG_QUERIES_NOT_USING_INDEXES
51 +LOG_SLAVE_UPDATES
52++LOG_SLOW_ADMIN_STATEMENTS
53 +LOG_SLOW_FILTER
54 +LOG_SLOW_QUERIES
55 +LOG_SLOW_RATE_LIMIT
56@@ -4360,7 +4361,7 @@
57 +WARNING_COUNT
58 --- /dev/null
59 +++ b/mysql-test/r/percona_server_variables_release.result
60-@@ -0,0 +1,344 @@
61+@@ -0,0 +1,346 @@
62 +SELECT Variable_name FROM INFORMATION_SCHEMA.SESSION_VARIABLES ORDER BY 1;
63 +Variable_name
64 +AUTOCOMMIT
65@@ -4543,6 +4544,7 @@
66 +LOG_OUTPUT
67 +LOG_QUERIES_NOT_USING_INDEXES
68 +LOG_SLAVE_UPDATES
69++LOG_SLOW_ADMIN_STATEMENTS
70 +LOG_SLOW_FILTER
71 +LOG_SLOW_QUERIES
72 +LOG_SLOW_RATE_LIMIT
73
74=== modified file 'patches/slow_extended.patch'
75--- patches/slow_extended.patch 2011-10-05 00:03:13 +0000
76+++ patches/slow_extended.patch 2011-10-08 01:59:25 +0000
77@@ -621,15 +621,6 @@
78 OPT_IGNORE_BUILTIN_INNODB,
79 OPT_BINLOG_DIRECT_NON_TRANS_UPDATE,
80 OPT_DEFAULT_CHARACTER_SET_OLD,
81-@@ -6135,7 +6149,7 @@
82- {"log-slow-admin-statements", OPT_LOG_SLOW_ADMIN_STATEMENTS,
83- "Log slow OPTIMIZE, ANALYZE, ALTER and other administrative statements "
84- "to the slow log if it is open.", &opt_log_slow_admin_statements,
85-- &opt_log_slow_admin_statements, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
86-+ &opt_log_slow_admin_statements, 0, GET_BOOL, OPT_ARG, 0, 0, 0, 0, 0, 0},
87- {"log-slow-slave-statements", OPT_LOG_SLOW_SLAVE_STATEMENTS,
88- "Log slow statements executed by slave thread to the slow log if it is open.",
89- &opt_log_slow_slave_statements,
90 @@ -6836,6 +6850,36 @@
91 "microsecond precision.",
92 &long_query_time, &long_query_time, 0, GET_DOUBLE,
93@@ -2600,3 +2591,81 @@
94 @@ -0,0 +1,2 @@
95 +SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
96 +SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
97+--- /dev/null
98++++ b/mysql-test/r/percona_log_slow_admin_statements-config_false.result
99+@@ -0,0 +1,6 @@
100++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
101++Variable_name Value
102++log_slow_admin_statements OFF
103++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
104++VARIABLE_NAME VARIABLE_VALUE
105++LOG_SLOW_ADMIN_STATEMENTS OFF
106+--- /dev/null
107++++ b/mysql-test/r/percona_log_slow_admin_statements-config_foo.result
108+@@ -0,0 +1,7 @@
109++call mtr.add_suppression("ignoring option '--log-slow-admin-statements' due to invalid value 'foo'");
110++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
111++Variable_name Value
112++log_slow_admin_statements OFF
113++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
114++VARIABLE_NAME VARIABLE_VALUE
115++LOG_SLOW_ADMIN_STATEMENTS OFF
116+--- /dev/null
117++++ b/mysql-test/r/percona_log_slow_admin_statements-config_true.result
118+@@ -0,0 +1,6 @@
119++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
120++Variable_name Value
121++log_slow_admin_statements ON
122++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
123++VARIABLE_NAME VARIABLE_VALUE
124++LOG_SLOW_ADMIN_STATEMENTS ON
125+--- /dev/null
126++++ b/mysql-test/t/percona_log_slow_admin_statements-config_false.cnf
127+@@ -0,0 +1,2 @@
128++[mysqld.1]
129++log-slow-admin-statements=false
130+--- /dev/null
131++++ b/mysql-test/t/percona_log_slow_admin_statements-config_false.test
132+@@ -0,0 +1,2 @@
133++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
134++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
135+--- /dev/null
136++++ b/mysql-test/t/percona_log_slow_admin_statements-config_foo.cnf
137+@@ -0,0 +1,2 @@
138++[mysqld.1]
139++log-slow-admin-statements=foo
140+--- /dev/null
141++++ b/mysql-test/t/percona_log_slow_admin_statements-config_foo.test
142+@@ -0,0 +1,3 @@
143++call mtr.add_suppression("ignoring option '--log-slow-admin-statements' due to invalid value 'foo'");
144++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
145++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
146+--- /dev/null
147++++ b/mysql-test/t/percona_log_slow_admin_statements-config_true.cnf
148+@@ -0,0 +1,2 @@
149++[mysqld.1]
150++log-slow-admin-statements=true
151+--- /dev/null
152++++ b/mysql-test/t/percona_log_slow_admin_statements-config_true.test
153+@@ -0,0 +1,2 @@
154++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
155++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
156+--- /dev/null
157++++ b/mysql-test/r/percona_log_slow_admin_statements-config.result
158+@@ -0,0 +1,6 @@
159++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
160++Variable_name Value
161++log_slow_admin_statements ON
162++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';
163++VARIABLE_NAME VARIABLE_VALUE
164++LOG_SLOW_ADMIN_STATEMENTS ON
165+--- /dev/null
166++++ b/mysql-test/t/percona_log_slow_admin_statements-config.cnf
167+@@ -0,0 +1,2 @@
168++[mysqld.1]
169++log-slow-admin-statements
170+--- /dev/null
171++++ b/mysql-test/t/percona_log_slow_admin_statements-config.test
172+@@ -0,0 +1,2 @@
173++SHOW GLOBAL VARIABLES like 'log_slow_admin_statements';
174++SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='log_slow_admin_statements';

Subscribers

People subscribed via source and target branches