Percona Server moved to https://jira.percona.com/projects/PS

Regression in log_slow_admin_statements handling in 5.1

Bug #860416 reported by Alexey Kopytov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Undecided
Oleg Tsarev
Percona Server moved to https://jira.percona.com/projects/PS 5.1.59-13.0

Bug Description

https://code.launchpad.net/~tsarev/percona-server/test51_691404/+merge/74982 has introduced a regression in 5.1. Before that change log_slow_admin_statements would not accept any string values except 'true' or 'false'. Now, the option accepts any string values. What's even worse, setting it to 'true' will not really enable the option.

Before the change:

1. log_slow_admin_statements=true (in my.cnf or command line) leads to a normal startup without warnings. "select @@log_slow_admin_statements;" returns "1";

2. log_slow_admin_statements=foo (in my.cnf or command line) leads to a warning during startup:

[Warning] ./mysqld: ignoring option '--log-slow-admin-statements' due to invalid value 'foo'

"select @@log_slow_admin_statements;" returns 0;

After the change:

1. log_slow_admin_statements=true (in my.cnf or command line) leads to a normal startup without warnings. "select @@log_slow_admin_statements;" returns "0";

2. log_slow_admin_statements=foo (in my.cnf or command line) leads to a normal startup without warnings;
"select @@log_slow_admin_statements;" returns 0;

Related branches

lp:~tsarev/percona-server/5.1_fix_bug_860416
Laurynas Biveinis (community): Approve
Diff: 139 lines (+82/-11)
2 files modified
patches/mysql-test.diff (+4/-2)
patches/slow_extended.patch (+78/-9)
lp:~tsarev/percona-server/5.1.59-porting
Stewart Smith (community): Approve
Diff: 10045 lines (+1224/-1990)
57 files modified
Makefile (+2/-2)
patches/bug53761.patch (+9/-9)
patches/bug580324.patch (+4/-4)
patches/bugfix48929.patch (+6/-6)
patches/control_online_alter_index.patch (+6/-6)
patches/error_pad.patch (+7/-7)
patches/i_s_innodb_buffer_pool_pages.patch (+2/-2)
patches/innodb_adjust_defaults.patch (+4/-4)
patches/innodb_admin_command_base.patch (+1/-1)
patches/innodb_buffer_pool_shm.patch (+3/-3)
patches/innodb_deadlock_count.patch (+5/-5)
patches/innodb_dict_size_limit.patch (+7/-7)
patches/innodb_expand_fast_index_creation.patch (+31/-31)
patches/innodb_expand_import.patch (+8/-8)
patches/innodb_expand_undo_slots.patch (+3/-3)
patches/innodb_extend_slow.patch (+56/-29)
patches/innodb_extra_rseg.patch (+5/-5)
patches/innodb_fake_changes.patch (+30/-30)
patches/innodb_fast_checksum.patch (+9/-9)
patches/innodb_fast_shutdown.patch (+8/-8)
patches/innodb_files_extend.patch (+22/-21)
patches/innodb_fix_misc.patch (+28/-562)
patches/innodb_io_patches.patch (+22/-22)
patches/innodb_kill_idle_transaction.patch (+8/-8)
patches/innodb_lru_dump_restore.patch (+11/-11)
patches/innodb_opt_lru_count.patch (+25/-25)
patches/innodb_overwrite_relay_log_info.patch (+8/-8)
patches/innodb_pass_corrupt_table.patch (+47/-47)
patches/innodb_purge_thread.patch (+11/-11)
patches/innodb_recovery_patches.patch (+5/-5)
patches/innodb_separate_doublewrite.patch (+17/-17)
patches/innodb_show_enhancements.patch (+1/-1)
patches/innodb_show_lock_name.patch (+6/-6)
patches/innodb_show_status.patch (+8/-8)
patches/innodb_show_sys_tables.patch (+1/-1)
patches/innodb_split_buf_pool_mutex.patch (+453/-715)
patches/innodb_stats.patch (+16/-16)
patches/innodb_swap_builtin_plugin.patch (+1/-1)
patches/innodb_thread_concurrency_timer_based.patch (+9/-9)
patches/log_connection_error.patch (+3/-3)
patches/mysql-syslog.patch (+9/-9)
patches/mysql-test.diff (+6/-4)
patches/mysql_dump_ignore_ct.patch (+4/-4)
patches/mysql_remove_eol_carret.patch (+5/-5)
patches/optimizer_fix.patch (+5/-5)
patches/percona-support.patch (+1/-1)
patches/profiling_slow.patch (+14/-14)
patches/query_cache_enhance.patch (+40/-40)
patches/response_time_distribution.patch (+22/-22)
patches/show_patches.patch (+9/-9)
patches/show_slave_status_nolock.patch (+10/-10)
patches/show_temp_51.patch (+10/-10)
patches/slow_extended.patch (+48/-48)
patches/sql_no_fcache.patch (+16/-16)
patches/suppress_log_warning_1592.patch (+6/-6)
patches/userstat.patch (+107/-107)
patches/utf8_general50_ci.patch (+4/-4)
lp:~tsarev/percona-server/merge-5.1_fix_bug_838725-and-5.1_fix_bug_860416
Alexey Kopytov (akopytov)
Changed in percona-server:
milestone: none → 5.1.59-13.0
assignee: nobody → Oleg Tsarev (tsarev)
status: New → Confirmed
Oleg Tsarev (tsarev)
Changed in percona-server:
status: Confirmed → In Progress
Oleg Tsarev (tsarev)
Changed in percona-server:
status: In Progress → Fix Committed
Oleg Tsarev (tsarev)
Changed in percona-server:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2690

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.