Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~tsarev/percona-server/5.1_fix_bug_716210

  1. 5.1_fix_bug_716210
  2. Merge into 5.1
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

LGTM with the the first comment below replied to and the rest of the changes. As far as I'm concerned, if the adjusted patch will be different from the current one with the changes below and nothing else, a new MP is not necessary.

- Can the argument of
  THD::restore_sub_statement_state_slow_extended(Sub_statement_state
  *backup) and the method void
  THD::reset_sub_statement_state_slow_extended(Sub_statement_state
  *backup) be constified? Please do so if yes.

- Line 314: s/save/saves

- Line 330: s/innodb_was used show/innodb_was_used shows

- Line 362: s/Belowing/Following, or remove the line
  altogether (line 364 is almost duplicate)

review: Approve

« Back to merge proposal