Code review comment for lp:~tsarev/percona-server/5.1-18205_03_wl47.patch

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

To whomever is going to work on this next:

  I'd make a little class encapsulating annotate_event,
  keep_annotate_event, print_annotate_event, free_annotate_event
  methods.

  If not the class, then make mysqlbinlog.cc new functions
  static. Put free_annotate_event, read_remote_annotate_event,
  keep_annotate_event, print_annotate_event in a section of file with
  function implementations, not in the middle of variable
  declarations. Put read_remote_annotate_event away from the other three.

  Adjust mysql-test/include/show_binlog_events.inc and
  show_binlog_events2.inc to refer to binlog_start_pos.inc.

  s/WL 47/MariaDB WL 47 everywhere.

  Line 3176: (MYQL_BIN_LOG::write): s/0/FALSE

  Lines 3306+: Annotate_rows_log_event constructors: use initializer
  lists for m_query_txt and m_query_len initializations too.

review: Needs Fixing

« Back to merge proposal