I'd make a little class encapsulating annotate_event,
keep_annotate_event, print_annotate_event, free_annotate_event
methods.
If not the class, then make mysqlbinlog.cc new functions
static. Put free_annotate_event, read_remote_annotate_event,
keep_annotate_event, print_annotate_event in a section of file with
function implementations, not in the middle of variable
declarations. Put read_remote_annotate_event away from the other three.
Adjust mysql-test/include/show_binlog_events.inc and
show_binlog_events2.inc to refer to binlog_start_pos.inc.
s/WL 47/MariaDB WL 47 everywhere.
Line 3176: (MYQL_BIN_LOG::write): s/0/FALSE
Lines 3306+: Annotate_rows_log_event constructors: use initializer
lists for m_query_txt and m_query_len initializations too.
To whomever is going to work on this next:
I'd make a little class encapsulating annotate_event, annotate_ event, print_annotate_ event, free_annotate_event
keep_
methods.
If not the class, then make mysqlbinlog.cc new functions event, read_remote_ annotate_ event, annotate_ event, print_annotate_ event in a section of file with annotate_ event away from the other three.
static. Put free_annotate_
keep_
function implementations, not in the middle of variable
declarations. Put read_remote_
Adjust mysql-test/ include/ show_binlog_ events. inc and binlog_ events2. inc to refer to binlog_ start_pos. inc.
show_
s/WL 47/MariaDB WL 47 everywhere.
Line 3176: (MYQL_BIN_ LOG::write) : s/0/FALSE
Lines 3306+: Annotate_ rows_log_ event constructors: use initializer
lists for m_query_txt and m_query_len initializations too.