Author: Oleg Tsarev
Revision Date: 2012-02-29 14:28:49 UTC

merge feature replication_slave_skip_columns

Author: Oleg Tsarev
Revision Date: 2012-02-29 12:19:52 UTC

Port feature slave_type_conversions_error_on_truncate

Author: Oleg Tsarev
Revision Date: 2012-02-23 16:00:05 UTC

Fri Feb 24 01:00:05 IRKT 2012

Author: Oleg Tsarev
Revision Date: 2012-02-22 06:35:36 UTC

add documentation for wl5151

Author: Oleg Tsarev
Revision Date: 2012-02-16 12:19:41 UTC

Merge feature WL #47 - annotate rows log events

Author: Oleg Tsarev
Revision Date: 2012-02-15 07:24:14 UTC

I renamed <name>_truncated methods to <name>, and "truncated" argument now has default value (0). I removed <name> methods, because their usage exactly correlate with new methods.

Author: Oleg Tsarev
Revision Date: 2012-02-10 12:45:31 UTC

Fixed code policy in wl47.patch.
Moved related tests and tests fixes from mysql-test-run.diff to wl47.patch.
Added (missed before) results for tests rpl.rpl_row_annotate_do, rpl.rpl_row_annotate_dont, binlog.binlog_row_annotate.

Author: Oleg Tsarev
Revision Date: 2012-02-08 10:02:40 UTC

merge lp:~tsarev/percona-server/18205_03_wl47.patch

Author: Oleg Tsarev
Revision Date: 2012-02-08 08:08:50 UTC

Fixed code polcy in wl47.patch.
Moved related tests and tests fixes from mysql-test-run.diff to wl47.patch.
Added (missed before) results for tests rpl.rpl_row_annotate_do, rpl.rpl_row_annotate_dont, binlog.binlog_row_annotate.

Author: Oleg Tsarev
Revision Date: 2012-02-06 06:02:47 UTC

Move changes in mysqlbinlog.result related to mysqlbinlog_fix.patch from mysql-test-rnt.diff to mysqlbinlog_fix.patch.

Author: Oleg Tsarev
Revision Date: 2012-02-01 14:20:40 UTC

1) Removed unnecessary sent_row_count_2: (sql/sql_class.h: class THD). Now uses sent_row_count instead of it.
2) Avoid copy-paste between THREAD_STATS and USER_STATS: moved counter to STATS structure, use it in USER_STATS and THREAD_STATS (sql/structs.h).
3) Replaced bunch of counters diff_* by STATS struct (sql/sql_class.h: class THD, also many small changes in different files).
4) Added increment of access_denied counter (different files, is related to incompleted port from Google patch).
5) Removed unnecessary LOCK_stats mutex (is related to incorrect port from Google patch).
6) Fixed incorrect kind of query detection (is related to incompleted port from Google patch):
  * sql/sql_yacc.yy: SQLCOM_SHOW_[CLIENT|USER|THREAD|TABLE|INDEX]_STATS instead of SQLCOM_SELECT
  * sql/sql_parse.cc: assign CF_STATUS_COMMAND flag for SHOW [CLIENT|USER|THREAD|TABLE|INDEX]_STATS commands
  Without this changes code in the THD::update_stats incorrect works.
7) Fixed comment for THD::get_client_host_port (incorrect moved in one of previous porting)
8) Removed ugly init_user_stats / init_thread_stats function (rudimentary used). Now I use direct memset(..., 0, ...) initialisation.
9) Renamed function update_global_user_stats to update_global_stats (because not only user_stats updated, thread_stats too)
10) Avoid copy-paste between update_global_user_stats_with_user and update_global_user_stats_with_thread by single function update_stats
11) Add set_connections function (related to incomplete port from Google patch) and add call to send_user_stats and send_thread_stats (bug #728082, bug #924872). Without this call statistcs from separated thread didn't aggregated to global_[client|thread|user]_stats.
12) Add counters cleanup to sql_parse.cc: mysql_reset_thd_for_next_command (related to incompleted port from Google patch)
13) Add wild-card processing to:
  * send_user_stats
  * send_thread_stats
  * fill_schema_table_stats
  * fill_schema_index_stats
Without this changes LIKE and WHERE works incorrectly (related to incompleted port from Google patch).
14) Removed unnecessary engine_type from TABLE STATS (changes related to changes from Percona).
15) Removed unnecessary add_thead_stats / add_user_stats functions.
16) Added DBUG_ENTER/DBUG_RETURN/DBUG_VOID_RETURN information to related functions.
17) Fixed code policy / added comments to function for all related code.
18) Added EXTENDED_FOR_USERSTAT macros to storage/myisam/ha_myisam.cc

Author: Oleg Tsarev
Revision Date: 2012-01-28 15:09:45 UTC

update from lp:percona-server/5.1

Author: Oleg Tsarev
Revision Date: 2012-01-28 02:35:26 UTC

fix tests

Author: Oleg Tsarev
Revision Date: 2012-01-26 17:35:33 UTC

fix fold_all/unfold_all

Author: Oleg Tsarev
Revision Date: 2012-01-25 02:16:08 UTC

5.5.20 basic port

Author: Oleg Tsarev
Revision Date: 2012-01-23 20:19:13 UTC

various changes & fixes

Author: Oleg Tsarev
Revision Date: 2012-01-16 10:12:28 UTC

fix bug in always
add warning about inconsistent stack traces

Author: Oleg Tsarev
Revision Date: 2012-01-11 05:32:17 UTC

add little example of incorrect work

Author: Oleg Tsarev
Revision Date: 2011-12-21 09:26:24 UTC

Wed Dec 21 18:26:24 IRKT 2011

Author: Oleg Tsarev
Revision Date: 2011-12-17 14:45:15 UTC

  Add tests:
    * select */* a comment \*/from t1;
    * select *# a comment \\\nfrom t1;
    * select *-- a comment \\\nfrom t1
    * select "\\\\"" /* not a comment */" from t1;
    * select "\\\\"" /*! not a comment */" from t1;

  Behavior was incorrect:
    * backslash-backslash-quote processed incorrectly (as backslash-quote)
    * backslash-star-slash processed incorrectly (as part of comment)
    * backslash inside comments and quotes` (this is also related to bugs #856404 and #705688 - go out arrays bound and memory corruption as result).

  Refactoring of query comments remover and cacheable query detector.
This changes simplify the query-cache-strip-comments option implementation and avoid future bugs.
  1) Rename class Query_Cache_Strip_Comments to Query_Without_Comments
  2) Fix bug inside "set" method: while I am allocating buffer for striped query I forgot about \0 in the end of query. After that memory is corrupted. This is related to bugs #856404 and #705688.
  3) Change logic of "set" inside Query_Without_Comments method - now thd->db_length used instead of sum "thd->db_length + 1 + QUERY_CACHE_FLAGS_SIZE"
  4) rename members of class Query_Cache_Strip_Comments: lenght => q_length, buffer_length => b_length
  5) Move class Query_Without_Comments (old Query_Cache_Strip_Comments) from file sql/query_cache_strip_comments.h to sql/sql_class.h. Move implementation of class's methods from sql_cache.cc to sql_class.cc
  6) Change interface of Query_Without_Comments - now this is just smart memory (re)allocation and memory free, without any logic of comment striping
  7) Remove file query_cache_strip_comments.h
  8) Remove class Query_Cache_Strip_Comments_Backup to Comments_Processor. Add logic of comments striping (from removed class Query_Cache_Strip_Comments).
  Add logic for check cacheability of query.
  9) Enum query_comments_parser::Kind. Describe part of query by following kinds:
   * Empty - end of query, empty query
   * Comment - single-line / multiline comments
   * WhiteSpace - space, tab, new line, carriage return
   * Special - part of query, which can be BEFORE the SELECT keyword in normal SELECT query (required for cacheable query detection) - WhiteSpace, Comment, or bracets ('(' and ')').
   * Another - any part of query except Special.
  10) Function query_comments_parser::analyze. Detect type of first part of query, return kind and pointer to begin/end
  11) Function query_comments_parser::remove_comments_from_query. Function remove all comments. Implemented using analyze. Function after remove some comment insert ' ' for avoid incorrect result. All sequences of whitespaces without another symbols replaced by single ' ' (including space which replaced the comment).
  12) Function query_comments_parses::skip_not_another - skip prefix before Another symbols (function hopes: first not another - SELECT. SELECT or not (cacheable or not) will checked immediately after funciton call).
  13) Function query_comments_parses::skip_defauls - default MySQL behavior - skip all open bracets ('('). Check for SELECT or not immediately after function call.
  Also fixed guard defines in it: from "_SQL_QUERY_STRIPC_COMMENTS_H_" to "_SQL_QUERY_CACHE_STRIP_COMMENTS_H_"
  14) Fixed header of query_cache_enhance.patch:
  from "query_cache_with_comments.patch" to "query_cache_enhance.patch"
  15) Little optimisation for '...''...' and "...""..."
  16) Change the memory allocation size - from 5.1.60 size is "(query_length + 1) + sizeof(size_t) + db_length + QUERY_CACHE_FLAGS_SIZE" instead of "(query_length + 1) + db_length + 1 + QUERY_CACHE_FLAGS_SIZE".
  Now query after \0 has also database length

Author: Oleg Tsarev
Revision Date: 2011-12-14 04:37:46 UTC

add documentation for row_based_replication_without_primary_key.patch

Author: Oleg Tsarev
Revision Date: 2011-12-13 12:15:13 UTC

increate sync_slave_with_master timeout to 3000

Author: Oleg Tsarev
Revision Date: 2011-12-13 12:00:13 UTC

increate sync_slave_with_master timeout to 3000

Author: Oleg Tsarev
Revision Date: 2011-11-19 00:04:15 UTC

add test-cases for innodb_stats_method and myisam_stats_method

Author: Oleg Tsarev
Revision Date: 2011-11-18 23:45:35 UTC

add test-cases for innodb_stats_method and myisam_stats_method

Author: Oleg Tsarev
Revision Date: 2011-11-18 19:52:23 UTC

add test-case for innodb_stats option

Author: Oleg Tsarev
Revision Date: 2011-11-02 15:27:18 UTC

Modified dbqp to deal with out-of-source builds

Author: Oleg Tsarev
Revision Date: 2011-11-02 14:14:46 UTC

add (incorrect) test case for bug #719386

Author: Valentine Gostev
Revision Date: 2011-10-30 01:13:38 UTC

Language fixes from gval

Author: Oleg Tsarev
Revision Date: 2011-10-24 14:21:21 UTC

fix potential bug for old firefox

Author: Oleg Tsarev
Revision Date: 2011-10-18 20:27:18 UTC

complete thread on input end
add "--quite" and "-q" options (hide errors)

Author: Oleg Tsarev
Revision Date: 2011-10-08 05:48:28 UTC

backup

Author: Oleg Tsarev
Revision Date: 2011-10-07 21:43:25 UTC

Added missing include for innodb_kill_idle_transaction.patch's tests

Author: Oleg Tsarev
Revision Date: 2011-10-07 20:55:28 UTC

Cumulative fixes of following bugs:
  * bug #838725 - percona_server_variables test doesn't run with "Test requires InnoDB."
  * bug #862378 - main.endspace fails sporadicly (merged to bug53761.patch)
  * bug #832528 - Backport the fix for MySQL bug #53761 to 5.1

Author: Oleg Tsarev
Revision Date: 2011-10-06 23:41:50 UTC

extend tests

Author: Oleg Tsarev
Revision Date: 2011-10-03 01:50:39 UTC

regenerate

Author: Oleg Tsarev
Revision Date: 2011-09-18 22:26:51 UTC

update mutex.patch

Author: Oleg Tsarev
Revision Date: 2011-09-16 13:54:32 UTC

remove references to Makefile.in from mwl36.patch and wl5151.patch

Author: Oleg Tsarev
Revision Date: 2011-09-15 07:46:42 UTC

update test-case

Author: Oleg Tsarev
Revision Date: 2011-09-12 15:53:10 UTC

Fix bug #831517: use_global_log_slow_control doesn't have default value

Author: Oleg Tsarev
Revision Date: 2011-09-12 13:33:10 UTC

Fixed bug #716210 - incorrect last_errno in slow-query-log

Author: Oleg Tsarev
Revision Date: 2011-09-12 13:28:11 UTC

propogate lp:percona-server

Author: Oleg Tsarev
Revision Date: 2011-09-12 13:14:21 UTC

propogate lp:percona-server/rnt-5.1

Author: Oleg Tsarev
Revision Date: 2011-09-12 13:12:48 UTC

fix show_slave_status_nolock.patch test and
SHOW SLAVE STATUS NOLOCK acquired lock in show_master_info
eventum issue number: 12952

Author: Oleg Tsarev
Revision Date: 2011-09-10 21:55:37 UTC

backup

Author: Oleg Tsarev
Revision Date: 2011-09-09 10:39:23 UTC

propogate lp:percona-server/rnt-5.1

Author: Oleg Tsarev
Revision Date: 2011-09-06 09:16:18 UTC

merge lp:~tsarev/percona-server/bug721176

Author: Oleg Tsarev
Revision Date: 2011-09-06 06:38:19 UTC

Fix bug #691404 - add log-slow-admin-statements to GLOBAL_VARIABLES
(dev-info: remove command-line option from sql/mysqld.cc, add sys_var_... to sql/sys_vars.cc (affects to CLI too))

Author: Oleg Tsarev
Revision Date: 2011-09-03 12:09:59 UTC

update from lp:percona-server/5.1

Author: Oleg Tsarev
Revision Date: 2011-08-25 13:18:58 UTC

Fixed bug #716210 - incorrect last_errno in slow-query-log

Author: Oleg Tsarev
Revision Date: 2011-08-17 14:52:29 UTC

fix replication_slave_skip_columns.patch tests:
1) replace table_id by # in SHOW BINLOG EVENTS
2) replace debug-log by log in SHOW BINLOG EVENTS

Author: Oleg Tsarev
Revision Date: 2011-08-17 14:37:46 UTC

fix tests of replication_slave_skip_columns.patch (insert no-debug option)

Author: Oleg Tsarev
Revision Date: 2011-08-14 19:58:30 UTC

Fixed bug in slave_type_conversions_error_on_truncate - double warning about overflow&truncate in Field_new_decimal::store_truncated.
Bug reproduced in test main.type_newdecimal.
Also simplified Field::warn_if_overflow_truncated.

Author: Oleg Tsarev
Revision Date: 2011-08-13 17:05:49 UTC

add support of mysqlbinlog

Author: Oleg Tsarev
Revision Date: 2011-08-05 01:10:00 UTC

fix fedora package build

Author: Oleg Tsarev
Revision Date: 2011-08-03 16:26:47 UTC

lp:~tsarev/percona-server/5.5-processlist_rows_stats-sporadic_fails-fix

Author: Oleg Tsarev
Revision Date: 2011-07-27 11:30:33 UTC

1. patches/innodb_bug60788.patch: fix offsets
2. patches/innodb_extend_slow.patch: fix offsets
3. patches/innodb_fix_misc.patch: fix offsets
4. patches/innodb_lru_dump_restore.patch: updated on 'quilt refresh'
5. patches/innodb_recovery_patches.patch: fix offsets
6. patches/innodb_split_buf_pool_mutex.patch: updated on 'quilt refresh'
7. patches/innodb_stats.patch: updated on 'quilt refresh'
8. patches/processlist_row_stats.patch: fix offsets
9. patches/response-time-distribution.patch: fix offsets
10. patches/slow_extended.patch: updated on 'quilt refresh'
11. patches/start-stop-messages.patch: fix offsets
12. patches/userstat.patch: fix offsets
13. update all patches: remove timestamp from header
14. update all patches: remove "diff -ruN a/... b/..." - this is not good, but not found solution for this yet.

Author: Oleg Tsarev
Revision Date: 2011-07-27 11:06:29 UTC

1. patches/bug813587.patch: fix offsets
2. patches/innodb_bug60788.patch: fix offsets
3. patches/innodb_extend_slow.patch: fix offsets
4. patches/innodb_fix_misc.patch: fix offsets
5. patches/innodb_lru_dump_restore.patch: updated on 'quilt refresh'
6. patches/innodb_recovery_patches.patch: fix offsets
7. patches/innodb_show_sys_tables.patch: updated on 'quilt refresh'
8. patches/innodb_stats.patch: updated on 'quilt refresh'
9. patches/percona-support.patch: updated on 'quilt refresh'
10. patches/response-time-distribution.patch: fix offsets
11. update all patches: remove timestamp from header
12. update all patches: remove "diff -ruN a/... b/..." - this is not good, but not found solution for this yet.

Author: Oleg Tsarev
Revision Date: 2011-07-13 11:36:24 UTC

1) Move all tests from mysql-test/slow_extended.patch to slow_extended.patch.
Now tests in "percona" suite
2) Rename all tests from percoa_slow_extended-X to X name
3) Extract start/stop/grep logic from tests to log_start/log_stop/log_grep includes
4) Remove tests mysql-test/slow_extended.patch/percona_slow_extended-use_global_long_query_time, because variable "use_global_long_query_time" was removed in 5.5 (and logic from this test) available in the slow_query_log_use_global_control.
5) Replace all SLEEP(X) by SET SESSION debug="+d,query_exec_time_X" or /* query_exec_time_X */
Also fixes bugs:
bug #794780 - "percona_slow_extended-microseconds_in_slow_extended sometimes fails"
bug #803071 - "add command-line variable setup test - log_slow_filter"
bug #803076 - "add command-line variable setup test - log_slow_slave_statements"
bug #803088 - "fix tests for log_slow_sp_statements:
bug #803093 - "add test for variable "log_slow_timestamp_every/slow_query_log_timestamp_always" (not command-line version)"
bug #803100 - "fix tests for use_global_log_slow_control/slow_query_log_use_global_control"
bug #803110 - "fix tests for slow_query_log_microseconds_timestamp/slow_query_log_timestamp_precision"
bug #803120 - "log_slow_verbosity ommited command-line tests in 5.5 "
bug #803137 - "rename percona_slow_extended-slave_innodb_stats.test to percona_slow_extended-log_slow_verbosity-innodb.test"
bug #760085 - "main.percona_slow_extended-slave_innodb_stats fails sporadically in 5.1.56 "
bug #803140 - "percona_slow_extended-min_examined_row_limit.test incorrect"

Author: Oleg Tsarev
Revision Date: 2011-07-13 11:36:24 UTC

1) Move all tests from mysql-test/slow_extended.patch to slow_extended.patch.
Now tests in "percona" suite
2) Rename all tests from percoa_slow_extended-X to X name
3) Extract start/stop/grep logic from tests to log_start/log_stop/log_grep includes
4) Remove tests mysql-test/slow_extended.patch/percona_slow_extended-use_global_long_query_time, because variable "use_global_long_query_time" was removed in 5.5 (and logic from this test) available in the slow_query_log_use_global_control.
5) Replace all SLEEP(X) by SET SESSION debug="+d,query_exec_time_X" or /* query_exec_time_X */
Also fixes bugs:
bug #794780 - "percona_slow_extended-microseconds_in_slow_extended sometimes fails"
bug #803071 - "add command-line variable setup test - log_slow_filter"
bug #803076 - "add command-line variable setup test - log_slow_slave_statements"
bug #803088 - "fix tests for log_slow_sp_statements:
bug #803093 - "add test for variable "log_slow_timestamp_every/slow_query_log_timestamp_always" (not command-line version)"
bug #803100 - "fix tests for use_global_log_slow_control/slow_query_log_use_global_control"
bug #803110 - "fix tests for slow_query_log_microseconds_timestamp/slow_query_log_timestamp_precision"
bug #803120 - "log_slow_verbosity ommited command-line tests in 5.5 "
bug #803137 - "rename percona_slow_extended-slave_innodb_stats.test to percona_slow_extended-log_slow_verbosity-innodb.test"
bug #760085 - "main.percona_slow_extended-slave_innodb_stats fails sporadically in 5.1.56 "
bug #803140 - "percona_slow_extended-min_examined_row_limit.test incorrect"

Author: Oleg Tsarev
Revision Date: 2011-07-07 22:39:10 UTC

backup

Author: Stewart Smith
Revision Date: 2011-06-30 23:28:59 UTC

merge fdatasync() usage for innodb log files

Author: Oleg Tsarev
Revision Date: 2011-06-21 21:57:02 UTC

Reason of bug #719386:
slow_extended.patch just enable slow query log, but doesn't touch start_time, start_utime and utime_after_lock variables.
This variables stored in THD instance, and touching just on start of stored procedure.
Now I update start_time, start_utime, utime_after_lock before every statement from SP (if log_slow_sp_statements enabled).
I also add test-case for this bug.

Author: Oleg Tsarev
Revision Date: 2011-06-13 23:43:24 UTC

BEFORE-FIX behaviour: ,/install_tests.sh always install all files from mysql-test/
AFTER-FIX behavior: ./install_tests.sh install tests just for patches listed in "series" file and from mysql-test/.
For every "name.patch" patch we have directory "mysql-test/name.patch/" with tests for this patch.
This script help to maintain patches, merge between different versions, backport patches with tests and so one.
My change fix bug #782391
My change included fix of bug #790199 already.
Also script print statistics of patch applying.

Author: Oleg Tsarev
Revision Date: 2011-06-11 22:07:21 UTC

fix install_tests.sh (Percona-Server- instead of Percona-Server)

Author: Oleg Tsarev
Revision Date: 2011-06-08 01:15:03 UTC

The reason of bug #786645: patch slow_extended.patch adds option "log_slow_verbosity" with value "profiling_use_getrusage".
This option enable/disable call "getrusage", but doesn't check status when uses variable changed by "getrusage".
As result valgrind show warning "potential use of uninitialized value".
Now I check status before access to changed variables.
This is actual for tests:
 * main.profiling
 * main.show_profile

Author: Oleg Tsarev
Revision Date: 2011-06-07 21:39:51 UTC

Reason of bug: when we run test under valgrind test work long time, and slow query log has extra query "call mtr.check_testcase();".
I disable slow query log on startup, and enable only when I need.

Author: Oleg Tsarev
Revision Date: 2011-03-10 13:05:44 UTC

backup

Author: Oleg Tsarev
Revision Date: 2010-09-21 17:24:34 UTC

improve

Author: Oleg Tsarev
Revision Date: 2010-09-21 00:00:27 UTC

alternate version

Author: Oleg Tsarev
Revision Date: 2010-09-01 19:39:23 UTC

complex version

Author: Oleg Tsarev
Revision Date: 2010-06-06 03:37:18 UTC

remove studio projects and solutions, add script for generating