Code review comment for lp:~tsabi/openerp-web/trunk-properi18nmark

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

> yes you right, in pyeval.js there is not too much real end user message, except pyeval.js:344:348 lines, and it has hardcoded english language specific code.

Well I don't know, it's the string representation of a Python timedelta object, which I don't know to be translated. If you have an OS in a non-english language, try creating a timedelta object and see what it prints to:

    > python -c 'import datetime; print datetime.timedelta(1, 1)'
    1 day, 0:00:01

if it returns some sort of localized string localizing it in pyeval could be considered, but if it does not I'd rather stick to the original behavior in the translation to javascript.

« Back to merge proposal