proxy-check-targets : lp:~troyanov/maas : Git : Code : MAAS

Get this branch:: git clone -b proxy-check-targets https://git.launchpad.net/~troyanov/maas

Only Anton Troyanov can upload to this branch. If you are Anton Troyanov please log in for upload directions.

Branch merges

Merged into maas:master

MAAS Lander: Approve on 2024-04-24

Jacopo Rota: Approve on 2024-04-24

Christian Grabowski: Approve on 2024-04-24

Branch information

Name:: proxy-check-targets

Repository:: lp:~troyanov/maas

Recent commits

35b7475... by Anton Troyanov on 2024-04-24

test(agent): region endpoints are unreachable

d5a190e... by Anton Troyanov on 2024-04-24

fix(agent): check if region endpoints are reachable

Region Controller might return IP:PORT that is not reachable by the
Agent (due to firewall configuration or network setup). Hence we should
add check if endpoints are reachable before applying them as targets
when configuring Agent HTTP reverse proxy service.

Resolves LP:2063220

Workflow logic is constrained by deterministic execution requirements.
In Go, Workflow Definition code cannot directly do the following:
- Call an external API, conduct a file I/O operation, talk to another service, etc

Normally we should use Activity for this scenario, however we are
confident and consider that we want to do this I/O inside the workflow.

But by having a blocking I/O you might get the following panic:
panic: Potential deadlock detected: workflow goroutine "root" didn't yield for over a second

It happens simply because the "root" goroutine was not scheduled for
execution. By using `workflow.Go` we don't mess with the scheduler and
we should worry about logic inside `workflow.Go` not take more than 1
second.

50bd23b... by Jones Ogolo <email address hidden> on 2024-04-19