Merge ~troyanov/maas:agent-create-rundir into maas:master

[Anton Troyanov]

fix(agent): create runDir if it doesn't exist

For SNAP install this folder is created by chrony, because chrony will create a
full path as defined for the PID file in the config [0]

We should not rely on chrony

if "SNAP" in os.environ:
    run_dir = get_maas_run_path()
    lines.append(f"dumpdir {run_dir / _NTP_DIR_NAME}")
    lines.append(f"pidfile {run_dir / _NTP_PID_NAME}")
    lines.append(f"bindcmdaddress {run_dir / _NTP_SOCK_NAME}")

[0]: src/provisioningserver/ntp/config.py

[MAAS Lander (maas-lander)]

UNIT TESTS
-b agent-create-rundir lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 59c39829115c278d81d2685ee6e2f5ce92a55e7e

review: Approve

[Christian Grabowski (cgrabowski)]

+1

review: Approve

diff --git a/src/maasagent/cmd/maas-agent/main.go b/src/maasagent/cmd/maas-agent/main.go
index c6b7f01..64faca8 100644
--- a/src/maasagent/cmd/maas-agent/main.go
+++ b/src/maasagent/cmd/maas-agent/main.go
@@ -150,8 +150,20 @@ func Run() int {
 		return 1
 	}
 
+	runDir := getRunDir()
+
+	_, err = os.Stat(runDir)
+	if os.IsNotExist(err) {
+		err = os.Mkdir(runDir, os.ModeDir|0755)
+	}
+
+	if err != nil {
+		log.Error().Err(err).Send()
+		return 1
+	}
+
 	powerService := power.NewPowerService(cfg.SystemID, &workerPool)
-	httpProxyService := httpproxy.NewHTTPProxyService(getRunDir(), cache)
+	httpProxyService := httpproxy.NewHTTPProxyService(runDir, cache)
 
 	workerPool = *worker.NewWorkerPool(cfg.SystemID, temporalClient,
 		worker.WithMainWorkerTaskQueueSuffix("agent:main"),