Merge ~troyanov/maas:configure-agent-retry into maas:master

[Anton Troyanov]

refactor: use configure-agent global timeout

Use WorkflowExecutionTimeout of configure-agent and let Temporal retry
all the child workflows and activities within this timeout.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b configure-agent-retry lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/5418/console
COMMIT: 08c561d622f7c1ed00bc1776f4794b6ea5ef3e9f

review: Needs Fixing

Unmerged commits

08c561d... by Anton Troyanov on 2024-04-30

refactor: use configure-agent global timeout

Use WorkflowExecutionTimeout of configure-agent and let Temporal retry
all the child workflows and activities within this timeout.

diff --git a/src/maasagent/internal/httpproxy/service.go b/src/maasagent/internal/httpproxy/service.go
index f4f694e..246a6b8 100644
--- a/src/maasagent/internal/httpproxy/service.go
+++ b/src/maasagent/internal/httpproxy/service.go
@@ -108,8 +108,7 @@ func (s *HTTPProxyService) Configure(ctx tworkflow.Context, systemID string) err
 	if err := tworkflow.ExecuteActivity(
 		tworkflow.WithActivityOptions(ctx,
 			tworkflow.ActivityOptions{
-				TaskQueue:              "region",
-				ScheduleToCloseTimeout: 60 * time.Second,
+				TaskQueue: "region",
 			}),
 		"get-region-controller-endpoints").
 		Get(ctx, &endpointsResult); err != nil {
diff --git a/src/maasagent/internal/power/service.go b/src/maasagent/internal/power/service.go
index b33dd0f..cbb9acf 100644
--- a/src/maasagent/internal/power/service.go
+++ b/src/maasagent/internal/power/service.go
@@ -24,7 +24,6 @@ import (
 	"os/exec"
 	"reflect"
 	"strings"
-	"time"
 
 	"go.temporal.io/sdk/activity"
 	tworker "go.temporal.io/sdk/worker"
@@ -82,8 +81,7 @@ func (s *PowerService) Configure(ctx tworkflow.Context, systemID string) error {
 	err := tworkflow.ExecuteActivity(
 		tworkflow.WithActivityOptions(ctx,
 			tworkflow.ActivityOptions{
-				TaskQueue:              "region",
-				ScheduleToCloseTimeout: 60 * time.Second,
+				TaskQueue: "region",
 			}),
 		"get-rack-controller-vlans", param).
 		Get(ctx, &vlansResult)
diff --git a/src/maastemporalworker/workflow/configure.py b/src/maastemporalworker/workflow/configure.py
index 23d2575..15b12f3 100644
--- a/src/maastemporalworker/workflow/configure.py
+++ b/src/maastemporalworker/workflow/configure.py
@@ -177,7 +177,6 @@ class ConfigureAgentWorkflow:
             param.system_id,
             id=f"configure-power-service:{param.system_id}",
             task_queue=f"{param.system_id}@agent:main",
-            retry_policy=RetryPolicy(maximum_attempts=1),
         )
 
         await workflow.execute_child_workflow(
@@ -185,5 +184,4 @@ class ConfigureAgentWorkflow:
             param.system_id,
             id=f"configure-httpproxy-service:{param.system_id}",
             task_queue=f"{param.system_id}@agent:main",
-            retry_policy=RetryPolicy(maximum_attempts=1),
         )