Merge ~troyanov/maas:agent-logs-remove-ts into maas:master
Status: | Merged |
---|---|
Approved by: | Adam Collard |
Approved revision: | 608339fa5b05fa3155bcb575b488598e746a64fa |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~troyanov/maas:agent-logs-remove-ts |
Merge into: | maas:master |
Diff against target: |
23 lines (+11/-1) 1 file modified
src/maasagent/cmd/maas-agent/main.go (+11/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Collard (community) | Approve | ||
MAAS Lander | Approve | ||
Review via email: mp+459647@code.launchpad.net |
Commit message
refactor(agent): remove timestamp from logs
MAAS Agent stdout is captured with systemd-cat
Because journal has it's own timestamp, we don't want to add extra
Before:
```
Jan 29 13:35:30 maas maas-agent[161449]: 1:35PM INF Logger is configured with log level "info"
Jan 29 13:35:30 maas maas-agent[161449]: 1:35PM INF Started Worker Namespace=default TaskQueue=
Jan 29 13:35:30 maas maas-agent[161449]: 1:35PM INF Service MAAS Agent started
```
After:
```
Jan 30 15:05:04 maas maas-agent[253279]: INF Logger is configured with log level "info"
Jan 30 15:05:04 maas maas-agent[253279]: INF Started Worker Namespace=default TaskQueue=
Jan 30 15:05:04 maas maas-agent[253279]: INF Service MAAS Agent started
```
I think the change is good, we should have tests that assert about the behaviour of the logger.