Merge ~troyanov/maas:ipmi-power-off-mode-settings into maas:master
Status: | Merged |
---|---|
Approved by: | Anton Troyanov |
Approved revision: | aba365a591d3c79fdd2bb18a2d5e81f8fc8836ae |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~troyanov/maas:ipmi-power-off-mode-settings |
Merge into: | maas:master |
Diff against target: |
43 lines (+15/-0) 2 files modified
src/provisioningserver/drivers/power/ipmi.py (+13/-0) src/provisioningserver/tests/test_power_driver_command.py (+2/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Peter Makowski | Approve | ||
Adam Collard (community) | Approve | ||
MAAS Lander | Approve | ||
Alberto Donato (community) | Approve | ||
Review via email: mp+455689@code.launchpad.net |
Commit message
fix: add power-off-mode to ipmi settings
Description of the change
Existing behaviour was:
```
if power_off_mode == "soft":
ipmipower_
else:
ipmipower_
```
This basically mimics the same approach that was exposed via API, where for the method `def power_off(self, request, system_id)` we had "hard" to be the default value:
```
stop_mode = request.
```
And also the Node model has defaults as "hard":
`def stop(self, user=None, stop_mode="hard", comment=None)`
The name for the exposed property is "power-off-mode" as thats how existing IPMI driver wants it (not the "stop_mode")
```
power_info.
```
+1