Code review comment for ~troyanov/maas:fix-2042645

Revision history for this message
Anton Troyanov (troyanov) wrote (last edit ):

We send parameters that we fetch from existing model methods (and it used to work this way).
Driver logic ignores unknown parameters, it's just maas-power CLI that chokes (because of ArgParse) and thats why this proposal is removing strict check for the CLI (to be on par with driver logic)

Extra parameters are added here:
`get_effective_power_parameters` from src/maasserver/models/node.py adds power_params["mac_address"] each time

If I understand correctly:
- `mac_address` is used only by IPMI
- `power_off_mode` is also used by IPMI
- `power_id` is used only by virsh?

(I didn't check all of them)

« Back to merge proposal