Merge ~troyanov/maas:rackd-nginx-conf into maas:master
Proposed by
Anton Troyanov
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Anton Troyanov | ||||
Approved revision: | a4c11bd4133dbfe0356e45bf1c17b99f2b8bf5cc | ||||
Merge reported by: | MAAS Lander | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~troyanov/maas:rackd-nginx-conf | ||||
Merge into: | maas:master | ||||
Diff against target: |
16 lines (+2/-2) 1 file modified
src/provisioningserver/templates/http/rackd.nginx.conf.template (+2/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Donato (community) | Approve | ||
MAAS Lander | Approve | ||
Review via email: mp+446625@code.launchpad.net |
Commit message
fix: use original Host value when proxy_set_header
Resolves LP:2022926
Description of the change
In regiond we do have proxy_set_header X-Forwarded-Host $http_host; which is used by Django stuff to build absolute URL
$http_host that we use to fill it basically takes original Host header information
http://
So why this fix is needed:
Because if in rackd config we set Host header to $host, we are losing port information. That leads to regiond having Host header without port, leading to $http_host not having port and breaking metadata_url
To post a comment you must log in.
UNIT TESTS
-b rackd-nginx-conf lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas
STATUS: SUCCESS 0356e45bf1c17b9 9f2b8bf5cc
COMMIT: a4c11bd4133dbfe