Merge ~troyanov/maas:fix-2003940 into maas:master

[Anton Troyanov]

fix(ws): incorrect storage amount

Combining multiple aggregations with annotate() will yield the wrong results
because joins are used instead of subqueries.

See related Django bug: https://code.djangoproject.com/ticket/10060

Resolves LP:2003940

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-2003940 lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2414/console
COMMIT: 7ba51c382953effa7049c41e70f69bf8e9900aed

review: Needs Fixing

[Anton Troyanov (troyanov)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-2003940 lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: d5d20f84973dfff5963d8a57dae36ef3c9b1423e

review: Approve

[Alberto Donato (ack)]

+1

you can probably drop tags and the filtering in the list() call as they shouldn't be needed

review: Approve

[Anton Troyanov (troyanov)]

It can be reproduced only if machine has tags and if filtering is applied. If I will remove filtering and tags -- then the test will work even without fix.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-2003940 lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 97283388f46f3cefb9b517aac7c13ce1f787c7aa

review: Approve

diff --git a/maasdb.dump b/maasdb.dump
new file mode 100644
index 0000000..f621513
Binary files /dev/null and b/maasdb.dump differ
diff --git a/src/maasserver/websockets/handlers/machine.py b/src/maasserver/websockets/handlers/machine.py
index ec02bf9..8e825a3 100644
--- a/src/maasserver/websockets/handlers/machine.py
+++ b/src/maasserver/websockets/handlers/machine.py
@@ -15,6 +15,7 @@ from django.db.models import (
     CharField,
     Count,
     F,
+    IntegerField,
     OuterRef,
     Subquery,
     Sum,
@@ -128,6 +129,15 @@ class MachineHandler(NodeHandler):
                 "partitiontable_set__partitions"
             )
         )
+        node_total_storage_query_set = (
+            Machine.objects.select_related("current_config")
+            .annotate(
+                storage=Sum(
+                    "current_config__blockdevice__physicalblockdevice__size"
+                )
+            )
+            .filter(pk=OuterRef("pk"))
+        )
         list_queryset = (
             Machine.objects.all()
             .select_related("owner", "zone", "domain", "bmc", "current_config")
@@ -173,10 +183,12 @@ class MachineHandler(NodeHandler):
                     .values("message")[:1]
                 ),
                 physical_disk_count=Count(
-                    "current_config__blockdevice__physicalblockdevice"
+                    "current_config__blockdevice__physicalblockdevice",
+                    distinct=True,
                 ),
-                total_storage=Sum(
-                    "current_config__blockdevice__physicalblockdevice__size"
+                total_storage=Subquery(
+                    node_total_storage_query_set.values("storage"),
+                    output_field=IntegerField(),
                 ),
                 pxe_mac=F("boot_interface__mac_address"),
                 fabric_name=F("boot_interface__vlan__fabric__name"),
diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py
index b5ab34c..40f5764 100644
--- a/src/maasserver/websockets/handlers/tests/test_machine.py
+++ b/src/maasserver/websockets/handlers/tests/test_machine.py
@@ -5989,6 +5989,24 @@ class TestMachineHandlerNewSchema(MAASServerTestCase):
         self.assertEqual(2, result["count"])
         self.assertEqual(2, result["groups"][0]["count"])
 
+    def test_filter_storage_counters(self):
+        user = factory.make_User()
+        node = factory.make_Machine(owner=user)
+        [node.tags.add(factory.make_Tag()) for _ in range(2)]
+
+        handler = MachineHandler(user, {}, None)
+        result = handler.list({"filter": {"free_text": node.hostname}})
+
+        self.assertEqual(1, result["count"])
+        self.assertEqual(
+            node.physicalblockdevice_set.count(),
+            result["groups"][0]["items"][0]["physical_disk_count"],
+        )
+        self.assertEqual(
+            round(node.physicalblockdevice_set.first().size / (1000**3), 1),
+            result["groups"][0]["items"][0]["storage"],
+        )
+
     def test_sort_alias(self):
         user = factory.make_User()
         fabrics = [factory.make_Fabric() for _ in range(2)]