Merge ~troyanov/maas:parent-child-host-vm into maas:master

[Anton Troyanov]

feat: add parent-child relation between vm and pod

[MAAS Lander (maas-lander)]

UNIT TESTS
-b parent-child-host-vm lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 82db7632bab046e4ba802cc03e1be3d015ad5df7

review: Approve

[Jack Lloyd-Walters (lloydwaltersj)]

LGTM

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b parent-child-host-vm lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 4a9edcab3c77e84f1d69de8b0e77b5417ec1baf8

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b parent-child-host-vm lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 95fbe195a1f78003d2ae6575ed7a333056f83105

review: Approve

f696419... by Anton Troyanov on 2022-09-06

fixup! feat: link machines that depend on each other

Add data migration step, to create parent-child relation for existing
VMs

[MAAS Lander (maas-lander)]

UNIT TESTS
-b parent-child-host-vm lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/547/consoleText
COMMIT: f87eda5766f6a6c8159637cba84d12c26704ed02

review: Needs Fixing

[Anton Troyanov (troyanov)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b parent-child-host-vm lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: f69641967ad21a66f1079197bdb9cf916afe7d6b

review: Approve

diff --git a/src/maasserver/migrations/maasserver/0280_set_parent_for_existing_vms.py b/src/maasserver/migrations/maasserver/0280_set_parent_for_existing_vms.py
new file mode 100644
index 0000000..5ce9ea2
--- /dev/null
+++ b/src/maasserver/migrations/maasserver/0280_set_parent_for_existing_vms.py
@@ -0,0 +1,28 @@
+# Generated by Django 3.2.12 on 2022-09-06 12:00
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("maasserver", "0279_store_vpd_metadata_for_nodedevice"),
+    ]
+
+    operations = [
+        migrations.RunSQL(
+            """
+            UPDATE maasserver_node AS node
+            SET parent_id = podhints_nodes.node_id
+            FROM
+              maasserver_bmc AS bmc,
+              maasserver_podhints AS podhints,
+              maasserver_podhints_nodes AS podhints_nodes
+            WHERE
+              node.bmc_id = bmc.id AND
+              podhints.pod_id = bmc.id AND
+              podhints_nodes.podhints_id = podhints.id AND
+              node.parent_id is NULL;
+            """
+        )
+    ]
diff --git a/src/maasserver/models/bmc.py b/src/maasserver/models/bmc.py
index 29e97dd..aab469c 100644
--- a/src/maasserver/models/bmc.py
+++ b/src/maasserver/models/bmc.py
@@ -901,6 +901,7 @@ class Pod(BMC):
             power_state=discovered_machine.power_state,
             dynamic=dynamic,
             pool=pool,
+            parent=self.host,
             zone=zone,
             bios_boot_method=discovered_machine.bios_boot_method,
             **kwargs,
diff --git a/src/maasserver/models/tests/test_bmc.py b/src/maasserver/models/tests/test_bmc.py
index a3e5547..05366ff 100644
--- a/src/maasserver/models/tests/test_bmc.py
+++ b/src/maasserver/models/tests/test_bmc.py
@@ -2099,6 +2099,19 @@ class TestPod(MAASServerTestCase, PodTestMixin):
             skip_commissioning=True,
         )
 
+    def test_create_machine_creates_machine_with_parent_child_relation(self):
+        self.patch(Machine, "set_default_storage_layout")
+        self.patch(Machine, "set_initial_networking_configuration")
+        self.patch(Machine, "start_commissioning")
+        project = factory.make_string()
+        host = factory.make_Machine_with_Interface_on_Subnet()
+        pod = factory.make_Pod(
+            host=host, pod_type="lxd", parameters={"project": project}
+        )
+        discovered_machine = self.make_discovered_machine()
+        machine = pod.create_machine(discovered_machine, factory.make_User())
+        self.assertEqual(machine.parent, host)
+
     def test_sync_pod_deletes_missing_machines(self):
         pod = factory.make_Pod()
         machine = factory.make_Node()