MAAS

Merge ~troyanov/maas:fix-1977951 into maas:master

  1. Git
  2. lp:~troyanov/maas
  3. fix-1977951
  4. Merge into master
Proposed by Anton Troyanov
Status: Merged
Approved by: Anton Troyanov
Approved revision: 8f2d34e040ad395863139d5902d6fc3fbc1c4af8
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~troyanov/maas:fix-1977951
Merge into: maas:master
Diff against target: 20 lines (+3/-3)
1 file modified
src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py (+3/-3)
Reviewer Review Type Date Requested Status
Björn Tillenius Approve
MAAS Lander Approve
Review via email: mp+424158@code.launchpad.net

Commit message

fix: LP:1977951

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b fix-1977951 lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/12852/console
COMMIT: d727bb79523d96a3c63d6908a4f641efde29a1ed

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b fix-1977951 lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/12855/console
COMMIT: 8f2d34e040ad395863139d5902d6fc3fbc1c4af8

review: Needs Fixing
Revision history for this message
Anton Troyanov (troyanov) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b fix-1977951 lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 8f2d34e040ad395863139d5902d6fc3fbc1c4af8

review: Approve
Revision history for this message
Björn Tillenius (bjornt) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
2index 2f4a9e9..e7c6633 100755
3--- a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
4+++ b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
5@@ -1013,12 +1013,12 @@ class Redfish(IPMIBase):
6
7 self.add_bmc_user()
8
9- self.redfish_ip = get_smbios_value(
10+ self._redfish_ip = get_smbios_value(
11 data, "IPv4 Redfish Service Address"
12 )
13- self.redfish_port = get_smbios_value(data, "Redfish Service Port")
14+ self._redfish_port = get_smbios_value(data, "Redfish Service Port")
15
16- if not all((self.redfish_ip, self.redfish_port)):
17+ if not all((self._redfish_ip, self._redfish_port)):
18 raise self.ConfigurationError(
19 "Missing Redfish Service information."
20 )

Subscribers

People subscribed via source and target branches