lp:~troyanov/maas

Author: Anton Troyanov
Author Date: 2023-11-01 16:16:58 UTC

fixup! feat: setup debug logger for maas-agent with rackd

Author: Anton Troyanov
Author Date: 2023-10-31 15:40:31 UTC

fix: pick different power CLI name when snap/deb

Author: Anton Troyanov
Author Date: 2023-10-27 21:55:40 UTC

fixup! refactor(temporal): UNIX socket for API activity

Fix circular import

Author: Anton Troyanov
Author Date: 2023-10-24 14:18:53 UTC

make update-initial-sql

Author: Anton Troyanov
Author Date: 2023-10-24 13:06:10 UTC

fix: update db_name in temporal.schema_version

Temporal stores initial value of the database name in migrations metadata.
When database is being dumped and restored with a different name, then
migrations will fail to apply. This change should fix this.

Author: Anton Troyanov
Author Date: 2023-10-23 12:16:23 UTC

doc(api): hide Switch Boot Order from API docs

We don't want some API endpoints to be displayed in the documentation,
because they are special handlers for MAAS internals.

Author: Anton Troyanov
Author Date: 2023-10-23 06:29:29 UTC

chore(ci): bump golangci-lint to 1.55.0

Author: Anton Troyanov
Author Date: 2023-10-20 12:14:54 UTC

feat: debug all http requests with headers

Author: Anton Troyanov
Author Date: 2023-10-20 07:21:16 UTC

fixup! feat(temporal): expose membership ports

Author: Anton Troyanov
Author Date: 2023-10-18 15:17:15 UTC

fixup! fix: update temporal schema path

Author: Anton Troyanov
Author Date: 2023-10-17 23:50:44 UTC

fix: update temporal schema path

Author: Anton Troyanov
Author Date: 2023-10-16 22:13:16 UTC

fix: permissions on /var/lib/maas/temporal

Author: Anton Troyanov
Author Date: 2023-10-16 12:48:03 UTC

fix: force save model object changes

Resolves LP:2015411 StaticIPAddress matching query does not exist

(cherry picked from commit cfb432e6e41ab097950c9550b5c61d3ca6d6bbb2)

Author: Anton Troyanov
Author Date: 2023-10-16 12:48:03 UTC

fix: force save model object changes

Resolves LP:2015411 StaticIPAddress matching query does not exist

(cherry picked from commit cfb432e6e41ab097950c9550b5c61d3ca6d6bbb2)

Author: Anton Troyanov
Author Date: 2023-10-14 21:23:24 UTC

fix: force save model object changes

Resolved LP:2015411 StaticIPAddress matching query does not exist

Author: Anton Troyanov
Author Date: 2023-10-11 22:23:32 UTC

fix: use normal activities instead of local ones

Local activities are experimental [0]

[0]: https://github.com/temporalio/sdk-python/blob/00878adc424046ed7854586120459a8a9731362a/README.md?plain=1#L630

Author: Anton Troyanov
Author Date: 2023-10-11 22:13:51 UTC

fix: set WorkflowExecutionTimeout

A Workflow Execution Timeout is the maximum time that a Workflow Execution can
be executing (have an Open status) including retries and any usage of
Continue As New.

Instead of setting Maximum Attempts, Temporalio recommends to
set WorkflowExecutionTimeout [0].

[0]: https://docs.temporal.io/retry-policies#maximum-attempts

Author: Anton Troyanov
Author Date: 2023-10-11 14:33:58 UTC

chore: clean up debian/copyright

Author: Anton Troyanov
Author Date: 2023-10-11 14:21:58 UTC

fix: move temporal dependency to maas-region-api

Author: Anton Troyanov
Author Date: 2023-10-03 10:48:16 UTC

chore(deps): bump pebble to 1.4.0

Author: Anton Troyanov
Author Date: 2023-10-03 09:18:29 UTC

Revert "fetch eventloop from temporal-worker when outside of async thread"

This reverts commit 9e575007317d8c0e23e5c9d3927a44da69d85131.

Author: Anton Troyanov
Author Date: 2023-09-29 13:37:25 UTC

chore(deps): bump temporal to 1.21.5

Resolves LP:2037727

Author: Anton Troyanov
Author Date: 2023-09-25 16:20:22 UTC

fix: change database owner

MAAS requires $dbc_dbuser to be an owner of $dbc_dbname.
One of the reasons is to be able to create new schemas (CREATE SCHEMA).

This is not new and documentation mentions the following configuration step:
```
sudo -u postgres \
  createdb -O \
  "$MAAS_DBUSER" \
  "$MAAS_DBNAME"
```

Unfortunately dbconfig-common used by MAAS configures `postgres` user as the
owner of `maasdb`.

Starting from dbconfig-common 2.0.22 the owner of the database
will be PostgreSQL user ($dbc_dbuser) [0]. For us this is the desired behavior.

Because dbconfig-common 2.0.22 is not available in 22.04, we have to fix
it ourselves for new installations and handle this case during upgrades
via deb packages.

In situations when MAAS cannot fix database ownership automatically we
want to inform MAAS user via deprecation notice [3].

[0]: https://salsa.debian.org/debian/dbconfig-common/-/blob/master/debian/changelog#L21
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010923
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021791
[3]: https://maas.io/deprecations/MD4

(cherry picked from commit ff9123154bd5041010f9032be7be8814d5e413cd)

Author: Anton Troyanov
Author Date: 2023-09-25 14:18:02 UTC

fixup! feat: add maas db owner deprecation notice

Author: Anton Troyanov
Author Date: 2023-09-25 09:28:08 UTC

chore(deps): bump github.com/canonical/lxd

Resolves LP:2028156

Author: Anton Troyanov
Author Date: 2023-09-22 07:41:50 UTC

Revert "remove call for temporal migrations in dbupgrade"

This reverts commit a9c203fdfed25d12c900766b218e2ab3d4f1f31f.

Author: Anton Troyanov
Author Date: 2023-09-01 12:54:10 UTC

fix: linter

Author: Anton Troyanov
Author Date: 2023-08-30 09:56:05 UTC

refactor!(temporal): change path /metrics/temporal

Author: Anton Troyanov
Author Date: 2023-08-29 22:07:46 UTC

fixup! feat(temporal): use postgresql database

Author: Anton Troyanov
Author Date: 2023-08-25 15:53:09 UTC

feat(temporal): use postgresql database

Author: Anton Troyanov
Author Date: 2023-08-27 09:15:11 UTC

refactor: move tags to log/tag

Author: Anton Troyanov
Author Date: 2023-08-26 05:56:40 UTC

refactor: pass schema instead of extra list

Author: Anton Troyanov
Author Date: 2023-08-24 20:06:54 UTC

fixup! refactor(temporal): explicit handle client fatal

Author: Anton Troyanov
Author Date: 2023-08-21 12:13:49 UTC

refactor(db)!: change database schema to maas

BREAKING CHANGE: database schema is changed to `maas`

MAAS is using default PostgreSQL schema `public` which makes impossible to
introduce new components that should work in a isolation.

Isolation of severtal applications controlled by MAAS can be achieved by
using PostgreSQL schemas, but default `public` schema is available to
everyone who has access to the database, thats why all MAAS related
objects are migrated to a separate schema.

Author: Anton Troyanov
Author Date: 2023-08-10 15:16:58 UTC

refactor(agent)!: changes Go module name

BREAKING CHANGE: Go module import path is changed

`go get` doesn't play well with Launchpad (git) [0]
We incorrectly assumed that module will be available at:
  launchpad.net/maas/maas/src/maasagent

It seems that correct way to get the module is to use this URL:
  git.launchpad.net/~maas-committers/maas.git/src/maasagent

However there will be an import error:
  module declares its path as: launchpad.net/maas/maas/src/maasagent
          but was required as: git.launchpad.net/~maas-committers/maas.git/src/maasagent

In order to solve this error, this commit changes module name to match URL
where it is available and `go get`-able.

We introduce maas.io/core that handles ?go-get=1
query parameter and provides metadata for `go get` utility.

Now Go modules can be imported as `maas.io/core/src/maasagent`

[0]: https://github.com/golang/go/blob/master/src/cmd/go/internal/vcs/vcs.go

Author: Anton Troyanov
Author Date: 2023-08-14 10:55:47 UTC

fixup! refactor: add struct tags, use underscore for wf

Author: Anton Troyanov
Author Date: 2023-08-13 18:43:52 UTC

refactor: check if worker exists before removing

Author: Anton Troyanov
Author Date: 2023-08-13 18:16:08 UTC

refactor: move workerpool to a separate package

Author: Anton Troyanov
Author Date: 2023-08-11 14:50:58 UTC

go.mod experimental (meta) subdir

Author: Anton Troyanov
Author Date: 2023-08-10 13:29:25 UTC

feat(agent): add prometheus metrics

Expose basic Go runtime metrics.

Add UNIX socket listener for MAAS Agent and expose it via HTTP
reverse proxy served by Rack Controller.

Author: Anton Troyanov
Author Date: 2023-08-10 11:04:06 UTC

feat(agent): propagate maas_uuid to the config

Author: Anton Troyanov
Author Date: 2023-08-08 22:17:32 UTC

feat(agent): add backoff for temporal worker init

Use exponential backoff and try for 60 sec before failing.

Author: Anton Troyanov
Author Date: 2023-08-08 14:55:38 UTC

fixup! refactor(temporal): pass client with codec

Author: Anton Troyanov
Author Date: 2023-08-08 11:46:36 UTC

fix(http): yield service_monitor call

Author: Anton Troyanov
Author Date: 2023-08-06 08:53:00 UTC

fix(temporal): _reload_service produce generator

Author: Anton Troyanov
Author Date: 2023-08-02 15:02:06 UTC

refactor: add default filename, use filepath.Clean

Author: Anton Troyanov
Author Date: 2023-07-28 16:21:14 UTC

chore(encryptor): move out from internal

We want to help users to build their own Temporal Codec Servers. Hence we should
allow them to import our codec package.

Author: Anton Troyanov
Author Date: 2023-07-28 10:21:10 UTC

fix(rackd): add missing maas-agent for deb package

Co-authored-by: Christian Grabowski <christian.grabowski@canonical.com>

Author: Anton Troyanov
Author Date: 2023-07-26 18:43:00 UTC

feat(temporal): manage maas-agent with rackd

Author: Anton Troyanov
Author Date: 2023-07-26 11:44:01 UTC

fix(temporal): fix service name for deb install

Author: Anton Troyanov
Author Date: 2023-07-25 09:15:54 UTC

feat(temporal): write logs to file

Author: Anton Troyanov
Author Date: 2023-07-25 09:24:01 UTC

chore(temporal): remove clusterMetadata config

clusterMetadata contains the local cluster information.
The information is used in Multi-Cluster Replication.

Temporal's Multi-Cluster Replication feature is considered experimental and not
subject to normal versioning and support policy.

MAAS is not using this feature.

Author: Anton Troyanov
Author Date: 2023-07-24 22:26:26 UTC

Revert "feat(temporal): log to file"

This reverts commit 964690fe3ff456f7a860b933bbbc5ff82b752e41.

Author: Anton Troyanov
Author Date: 2023-07-24 11:18:29 UTC

chore(maasagent): go get -u

Author: Anton Troyanov
Author Date: 2023-07-21 23:40:16 UTC

fixup! feat(temporal): add check IPs workflow

Author: Anton Troyanov
Author Date: 2023-07-19 17:06:55 UTC

Revert "ci: debug utilities/get_golangci-lint"

This reverts commit 42572ef2cd7daccbdc818f437490e47278e7706f.

Author: Anton Troyanov
Author Date: 2023-07-12 18:04:56 UTC

fix: use original Host value when proxy_set_header

Resolves LP:2022926

(cherry picked from commit 0a9ac75f7875dfad198ccaa4f2e322fa6521f38f)

Author: Anton Troyanov
Author Date: 2023-07-12 18:04:56 UTC

fix: use original Host value when proxy_set_header

Resolves LP:2022926

(cherry picked from commit 0a9ac75f7875dfad198ccaa4f2e322fa6521f38f)

Author: Anton Troyanov
Author Date: 2023-07-12 18:04:56 UTC

fix: use original Host value when proxy_set_header

Resolves LP:2022926

(cherry picked from commit 0a9ac75f7875dfad198ccaa4f2e322fa6521f38f)

Author: Anton Troyanov
Author Date: 2023-07-12 13:26:30 UTC

fix: use original Host value when proxy_set_header

Resolves LP:2022926

Author: Anton Troyanov
Author Date: 2023-07-12 12:22:06 UTC

fixup! feat(temporal): add temporal service

Author: Anton Troyanov
Author Date: 2023-07-11 10:50:42 UTC

feat: CheckIP without usage of external tools

This commit adds CheckIP implementation in pure Go without usage of
external tools like `ping` or `ip`.

However Rack Controller will continue to use existing approach until
other required changes will be made.

Author: Anton Troyanov
Author Date: 2023-06-28 14:54:12 UTC

fixup! ci(temporal): bundle temporal for snap/deb

Author: Anton Troyanov
Author Date: 2023-06-13 15:14:26 UTC

ci: add test-race as a separate target

Author: Anton Troyanov
Author Date: 2023-06-12 18:29:30 UTC

fix(ci): return proper code from find -execdir

-execdir command {} + always returns true,
-execdir command {} ; returns true only if command returns 0.

Author: Anton Troyanov
Author Date: 2023-06-12 15:55:51 UTC

fix(ci): vendor as a prerequisite for test

Author: Anton Troyanov
Author Date: 2023-06-06 10:11:08 UTC

fixup! fix: raise ConfigurationError if dmidecode missing

Author: Anton Troyanov
Author Date: 2023-06-02 11:27:09 UTC

ci(go): update golangci linter, enable zerologlint

Author: Anton Troyanov
Author Date: 2023-05-26 12:15:12 UTC

refactor: remove extra func call

Author: Anton Troyanov
Author Date: 2023-05-24 16:11:25 UTC

feat(metrics): collect usage of tags

In order to identify how tags are being used, we want to collect
statistics about:
- total tags
- automatic tags
- tags with kernel options

Author: Anton Troyanov
Author Date: 2023-05-24 12:22:04 UTC

feat(metrics): collect usage of DHCP snippets

In order to identify how often DHCP snippets feature is used, we should
collect usage statistics.

Author: Anton Troyanov
Author Date: 2023-05-16 10:38:16 UTC

fixup! bump pylxd version

Because 2.3.2 is not released yet, any pre-release version will fail to
conform previously required version constraint.

```
dpkg --compare-versions 2.3.2~alpha1-431-10-g.fe37358~ubuntu22.04.1 ge 2.3.2
```

This commit makes a more specific version constraint that should work
for both released and pre-release versions.

This constraint is needed to avoid 2.3.2~alpha1-420-10-g.72426bf~ubuntu22.04.1

Resolves LP:2019229

Author: Anton Troyanov
Author Date: 2023-05-15 19:49:43 UTC

fix(systest): explicit vendor in packaging-tarball

Author: Anton Troyanov
Author Date: 2023-05-12 00:16:27 UTC

fixup! feat(api): expose enable_hw_sync

Author: Anton Troyanov
Author Date: 2023-05-10 08:32:18 UTC

chore: name cmd folders with maas- prefix

Author: Anton Troyanov
Author Date: 2023-05-08 16:12:49 UTC

chore: simplify assert call

Author: Anton Troyanov
Author Date: 2023-05-06 10:23:44 UTC

feat(netmon)!: remove ARP logic from python code

Author: Anton Troyanov
Author Date: 2023-05-04 14:52:17 UTC

fix(ci): export OUT_PREFIX from parent make

Author: Anton Troyanov
Author Date: 2023-05-04 11:23:22 UTC

fix: maasagent parallel make, build target

Author: Anton Troyanov
Author Date: 2023-05-03 14:15:08 UTC

chore: add lint-go-fix target

--fix
  Fix found issues (if it's supported by the linter)

List of linters that support Autofix can be found here [0]

[0] https://golangci-lint.run/usage/linters/

Author: Anton Troyanov
Author Date: 2023-05-01 11:06:13 UTC

fixup! ci: improve golangci-lint settings

Author: Anton Troyanov
Author Date: 2023-04-27 18:43:25 UTC

chore: remove debug artefacts

Author: Anton Troyanov
Author Date: 2023-04-27 13:16:04 UTC

chore(ci): remove verbose print from golangci-lint

Author: Anton Troyanov
Author Date: 2023-04-27 11:48:52 UTC

fix(ws): incorrect storage amount

Combining multiple aggregations with annotate() will yield the wrong results
because joins are used instead of subqueries.

See related Django bug: https://code.djangoproject.com/ticket/10060

Resolves LP:2003940

Author: Anton Troyanov
Author Date: 2023-04-27 11:20:28 UTC

fix(ws): incorrect storage amount

Combining multiple aggregations with annotate() will yield the wrong results
because joins are used instead of subqueries.

See related Django bug: https://code.djangoproject.com/ticket/10060

Resolves LP:2003940

Author: Anton Troyanov
Author Date: 2023-04-24 10:53:17 UTC

refactor: remove redundant else?

Author: Anton Troyanov
Author Date: 2023-04-21 15:16:35 UTC

ci: add maas-netmon snap

Author: Anton Troyanov
Author Date: 2023-04-21 13:05:39 UTC

fix: sudoers filename

Author: Anton Troyanov
Author Date: 2023-04-20 14:29:19 UTC

fix: no lint target for maasagent

Author: Anton Troyanov
Author Date: 2023-04-19 17:38:06 UTC

fixup! fixup! ci: change makefile targets related to go lint

Author: Anton Troyanov
Author Date: 2023-04-19 12:09:42 UTC

fixup! fixup! docs: add go-style-guide

Author: Anton Troyanov
Author Date: 2023-04-05 08:17:01 UTC

chore: remove maas-test-enlistment script

Author: Anton Troyanov
Author Date: 2023-04-04 17:15:11 UTC

chore: remove dhcp-monitor-script

Author: Anton Troyanov
Author Date: 2023-03-20 15:31:29 UTC

fix(cli): follow maascli import boundaries

- Remove provisioningserver related import
- Update utilities/check-imports for maascli

Resolves LP:1986590

Author: Anton Troyanov
Author Date: 2023-03-20 15:31:29 UTC

fix(cli): follow maascli import boundaries

- Remove provisioningserver related import
- Move maasserver.vault to a local import
- Update utilities/check-imports for maascli

Resolves LP:1986590

(cherry picked from commit 1f7965043fb2c1586f7d4ba17d3645ffa5a0f8e2)

Author: Anton Troyanov
Author Date: 2023-03-20 16:00:39 UTC

chore(cli): include str(SSLError) in CommandError

(cherry picked from commit 054c51921c64b02def247d8b0c8d7a7b4d1b2616)

Author: Anton Troyanov
Author Date: 2023-03-20 16:00:39 UTC

chore(cli): include str(SSLError) in CommandError

(cherry picked from commit 054c51921c64b02def247d8b0c8d7a7b4d1b2616)

Author: Anton Troyanov
Author Date: 2023-03-20 15:05:55 UTC

fix(cli): reuse existing CA cert

Resolves LP:2012139

(cherry picked from commit ca3a5d0826694d0d12ff9ab93f813e2be446cb2e)

Author: Anton Troyanov
Author Date: 2023-03-20 15:05:55 UTC

fix(cli): reuse existing CA cert

Resolves LP:2012139

(cherry picked from commit ca3a5d0826694d0d12ff9ab93f813e2be446cb2e)

Author: Anton Troyanov
Author Date: 2023-03-18 05:08:24 UTC

chore(cli): include str(SSLError) in CommandError