drizzle-jdbc

Merge lp:~trond-norbye/drizzle-jdbc/trunk into lp:drizzle-jdbc

  1. trunk
  2. Merge into trunk
Proposed by Trond Norbye
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trond-norbye/drizzle-jdbc/trunk
Merge into: lp:drizzle-jdbc
Diff against target: None lines
To merge this branch: bzr merge lp:~trond-norbye/drizzle-jdbc/trunk
Reviewer Review Type Date Requested Status
Marcus Eriksson Approve
Review via email: mp+6777@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Trond Norbye (trond-norbye) wrote :

Do not use class.toString() to get the logger, but class.getName(). class.toString() will prefix the string with either "class " or "interface ", making it harder for users to get the logger to make it more quiet ;)

Revision history for this message
Marcus Eriksson (krummas) :
review: Approve
lp:~trond-norbye/drizzle-jdbc/trunk updated
106. By Marcus Eriksson <email address hidden>

merge trond

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/main/java/org/drizzle/jdbc/Driver.java'
--- src/main/java/org/drizzle/jdbc/Driver.java 2009-05-20 16:24:21 +0000
+++ src/main/java/org/drizzle/jdbc/Driver.java 2009-05-25 12:55:09 +0000
@@ -29,7 +29,7 @@
29 * Time: 7:46:09 AM29 * Time: 7:46:09 AM
30 */30 */
31public class Driver implements java.sql.Driver {31public class Driver implements java.sql.Driver {
32 private static final Logger log = Logger.getLogger(Driver.class.toString());32 private static final Logger log = Logger.getLogger(Driver.class.getName());
3333
34 static {34 static {
35 try {35 try {
3636
=== modified file 'src/main/java/org/drizzle/jdbc/DrizzleDatabaseMetaData.java'
--- src/main/java/org/drizzle/jdbc/DrizzleDatabaseMetaData.java 2009-05-17 19:00:27 +0000
+++ src/main/java/org/drizzle/jdbc/DrizzleDatabaseMetaData.java 2009-05-25 12:55:09 +0000
@@ -23,7 +23,7 @@
23 private final String url;23 private final String url;
24 private final String username;24 private final String username;
25 private final Connection connection;25 private final Connection connection;
26 private final static Logger log = Logger.getLogger(DrizzleDatabaseMetaData.class.toString());26 private final static Logger log = Logger.getLogger(DrizzleDatabaseMetaData.class.getName());
2727
28 /**28 /**
29 * Retrieves whether the current user can call all the procedures29 * Retrieves whether the current user can call all the procedures
3030
=== modified file 'src/main/java/org/drizzle/jdbc/DrizzlePreparedStatement.java'
--- src/main/java/org/drizzle/jdbc/DrizzlePreparedStatement.java 2009-05-25 08:21:30 +0000
+++ src/main/java/org/drizzle/jdbc/DrizzlePreparedStatement.java 2009-05-25 12:55:09 +0000
@@ -33,7 +33,7 @@
33 * Time: 10:49:42 PM33 * Time: 10:49:42 PM
34 */34 */
35public class DrizzlePreparedStatement extends DrizzleStatement implements PreparedStatement {35public class DrizzlePreparedStatement extends DrizzleStatement implements PreparedStatement {
36 private final static Logger log = Logger.getLogger(DrizzlePreparedStatement.class.toString());36 private final static Logger log = Logger.getLogger(DrizzlePreparedStatement.class.getName());
37 private ParameterizedQuery dQuery;37 private ParameterizedQuery dQuery;
3838
39 public DrizzlePreparedStatement(Protocol protocol, DrizzleConnection drizzleConnection, String query, QueryFactory queryFactory) {39 public DrizzlePreparedStatement(Protocol protocol, DrizzleConnection drizzleConnection, String query, QueryFactory queryFactory) {
4040
=== modified file 'src/main/java/org/drizzle/jdbc/DrizzleResultSetMetaData.java'
--- src/main/java/org/drizzle/jdbc/DrizzleResultSetMetaData.java 2009-05-21 20:42:14 +0000
+++ src/main/java/org/drizzle/jdbc/DrizzleResultSetMetaData.java 2009-05-25 12:55:09 +0000
@@ -27,7 +27,7 @@
2727
28 */28 */
29public class DrizzleResultSetMetaData implements ResultSetMetaData {29public class DrizzleResultSetMetaData implements ResultSetMetaData {
30 private final static Logger log = Logger.getLogger(DrizzleResultSetMetaData.class.toString());30 private final static Logger log = Logger.getLogger(DrizzleResultSetMetaData.class.getName());
31 private final List<ColumnInformation> fieldPackets;31 private final List<ColumnInformation> fieldPackets;
3232
33 public DrizzleResultSetMetaData(List<ColumnInformation> fieldPackets) {33 public DrizzleResultSetMetaData(List<ColumnInformation> fieldPackets) {
3434
=== modified file 'src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleParameterizedQuery.java'
--- src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleParameterizedQuery.java 2009-05-25 10:45:44 +0000
+++ src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleParameterizedQuery.java 2009-05-25 12:55:09 +0000
@@ -26,7 +26,7 @@
2626
27 */27 */
28public class DrizzleParameterizedQuery implements ParameterizedQuery {28public class DrizzleParameterizedQuery implements ParameterizedQuery {
29 private final static Logger log = Logger.getLogger(DrizzleParameterizedQuery.class.toString());29 private final static Logger log = Logger.getLogger(DrizzleParameterizedQuery.class.getName());
30 private Map<Integer, ParameterHolder> parameters;30 private Map<Integer, ParameterHolder> parameters;
31 private final int paramCount;31 private final int paramCount;
32 private final String query;32 private final String query;
3333
=== modified file 'src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleQuery.java'
--- src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleQuery.java 2009-05-17 19:00:27 +0000
+++ src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleQuery.java 2009-05-25 12:55:09 +0000
@@ -21,7 +21,7 @@
2121
22 */22 */
23public class DrizzleQuery implements Query {23public class DrizzleQuery implements Query {
24 private final static Logger log = Logger.getLogger(DrizzleQuery.class.toString());24 private final static Logger log = Logger.getLogger(DrizzleQuery.class.getName());
25 protected final String query;25 protected final String query;
26 public DrizzleQuery(String query) {26 public DrizzleQuery(String query) {
27 this.query=query;27 this.query=query;
2828
=== modified file 'src/main/java/org/drizzle/jdbc/internal/drizzle/DrizzleProtocol.java'
--- src/main/java/org/drizzle/jdbc/internal/drizzle/DrizzleProtocol.java 2009-05-24 20:52:58 +0000
+++ src/main/java/org/drizzle/jdbc/internal/drizzle/DrizzleProtocol.java 2009-05-25 12:55:09 +0000
@@ -37,7 +37,7 @@
37 * Time: 4:06:26 PM37 * Time: 4:06:26 PM
38 */38 */
39public class DrizzleProtocol implements Protocol {39public class DrizzleProtocol implements Protocol {
40 private final static Logger log = Logger.getLogger(DrizzleProtocol.class.toString());40 private final static Logger log = Logger.getLogger(DrizzleProtocol.class.getName());
41 private boolean connected=false;41 private boolean connected=false;
42 private final Socket socket;42 private final Socket socket;
43 private final BufferedOutputStream writer;43 private final BufferedOutputStream writer;
4444
=== modified file 'src/main/java/org/drizzle/jdbc/internal/mysql/MySQLProtocol.java'
--- src/main/java/org/drizzle/jdbc/internal/mysql/MySQLProtocol.java 2009-05-21 20:42:14 +0000
+++ src/main/java/org/drizzle/jdbc/internal/mysql/MySQLProtocol.java 2009-05-25 12:55:09 +0000
@@ -38,7 +38,7 @@
38 * Time: 4:06:26 PM38 * Time: 4:06:26 PM
39 */39 */
40public class MySQLProtocol implements Protocol {40public class MySQLProtocol implements Protocol {
41 private final static Logger log = Logger.getLogger(MySQLProtocol.class.toString());41 private final static Logger log = Logger.getLogger(MySQLProtocol.class.getName());
42 private boolean connected=false;42 private boolean connected=false;
43 private final Socket socket;43 private final Socket socket;
44 private final BufferedOutputStream writer;44 private final BufferedOutputStream writer;

Subscribers

People subscribed via source and target branches

to all changes: