drizzle-jdbc

Merge lp:~trond-norbye/drizzle-jdbc/trunk into lp:drizzle-jdbc

  1. trunk
  2. Merge into trunk
Proposed by Trond Norbye
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trond-norbye/drizzle-jdbc/trunk
Merge into: lp:drizzle-jdbc
Diff against target: None lines
To merge this branch: bzr merge lp:~trond-norbye/drizzle-jdbc/trunk
Reviewer Review Type Date Requested Status
Marcus Eriksson Approve
Review via email: mp+6777@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Trond Norbye (trond-norbye) wrote :

Do not use class.toString() to get the logger, but class.getName(). class.toString() will prefix the string with either "class " or "interface ", making it harder for users to get the logger to make it more quiet ;)

Revision history for this message
Marcus Eriksson (krummas) :
review: Approve
lp:~trond-norbye/drizzle-jdbc/trunk updated
106. By Marcus Eriksson <email address hidden>

merge trond

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/main/java/org/drizzle/jdbc/Driver.java'
2--- src/main/java/org/drizzle/jdbc/Driver.java 2009-05-20 16:24:21 +0000
3+++ src/main/java/org/drizzle/jdbc/Driver.java 2009-05-25 12:55:09 +0000
4@@ -29,7 +29,7 @@
5 * Time: 7:46:09 AM
6 */
7 public class Driver implements java.sql.Driver {
8- private static final Logger log = Logger.getLogger(Driver.class.toString());
9+ private static final Logger log = Logger.getLogger(Driver.class.getName());
10
11 static {
12 try {
13
14=== modified file 'src/main/java/org/drizzle/jdbc/DrizzleDatabaseMetaData.java'
15--- src/main/java/org/drizzle/jdbc/DrizzleDatabaseMetaData.java 2009-05-17 19:00:27 +0000
16+++ src/main/java/org/drizzle/jdbc/DrizzleDatabaseMetaData.java 2009-05-25 12:55:09 +0000
17@@ -23,7 +23,7 @@
18 private final String url;
19 private final String username;
20 private final Connection connection;
21- private final static Logger log = Logger.getLogger(DrizzleDatabaseMetaData.class.toString());
22+ private final static Logger log = Logger.getLogger(DrizzleDatabaseMetaData.class.getName());
23
24 /**
25 * Retrieves whether the current user can call all the procedures
26
27=== modified file 'src/main/java/org/drizzle/jdbc/DrizzlePreparedStatement.java'
28--- src/main/java/org/drizzle/jdbc/DrizzlePreparedStatement.java 2009-05-25 08:21:30 +0000
29+++ src/main/java/org/drizzle/jdbc/DrizzlePreparedStatement.java 2009-05-25 12:55:09 +0000
30@@ -33,7 +33,7 @@
31 * Time: 10:49:42 PM
32 */
33 public class DrizzlePreparedStatement extends DrizzleStatement implements PreparedStatement {
34- private final static Logger log = Logger.getLogger(DrizzlePreparedStatement.class.toString());
35+ private final static Logger log = Logger.getLogger(DrizzlePreparedStatement.class.getName());
36 private ParameterizedQuery dQuery;
37
38 public DrizzlePreparedStatement(Protocol protocol, DrizzleConnection drizzleConnection, String query, QueryFactory queryFactory) {
39
40=== modified file 'src/main/java/org/drizzle/jdbc/DrizzleResultSetMetaData.java'
41--- src/main/java/org/drizzle/jdbc/DrizzleResultSetMetaData.java 2009-05-21 20:42:14 +0000
42+++ src/main/java/org/drizzle/jdbc/DrizzleResultSetMetaData.java 2009-05-25 12:55:09 +0000
43@@ -27,7 +27,7 @@
44
45 */
46 public class DrizzleResultSetMetaData implements ResultSetMetaData {
47- private final static Logger log = Logger.getLogger(DrizzleResultSetMetaData.class.toString());
48+ private final static Logger log = Logger.getLogger(DrizzleResultSetMetaData.class.getName());
49 private final List<ColumnInformation> fieldPackets;
50
51 public DrizzleResultSetMetaData(List<ColumnInformation> fieldPackets) {
52
53=== modified file 'src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleParameterizedQuery.java'
54--- src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleParameterizedQuery.java 2009-05-25 10:45:44 +0000
55+++ src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleParameterizedQuery.java 2009-05-25 12:55:09 +0000
56@@ -26,7 +26,7 @@
57
58 */
59 public class DrizzleParameterizedQuery implements ParameterizedQuery {
60- private final static Logger log = Logger.getLogger(DrizzleParameterizedQuery.class.toString());
61+ private final static Logger log = Logger.getLogger(DrizzleParameterizedQuery.class.getName());
62 private Map<Integer, ParameterHolder> parameters;
63 private final int paramCount;
64 private final String query;
65
66=== modified file 'src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleQuery.java'
67--- src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleQuery.java 2009-05-17 19:00:27 +0000
68+++ src/main/java/org/drizzle/jdbc/internal/common/query/DrizzleQuery.java 2009-05-25 12:55:09 +0000
69@@ -21,7 +21,7 @@
70
71 */
72 public class DrizzleQuery implements Query {
73- private final static Logger log = Logger.getLogger(DrizzleQuery.class.toString());
74+ private final static Logger log = Logger.getLogger(DrizzleQuery.class.getName());
75 protected final String query;
76 public DrizzleQuery(String query) {
77 this.query=query;
78
79=== modified file 'src/main/java/org/drizzle/jdbc/internal/drizzle/DrizzleProtocol.java'
80--- src/main/java/org/drizzle/jdbc/internal/drizzle/DrizzleProtocol.java 2009-05-24 20:52:58 +0000
81+++ src/main/java/org/drizzle/jdbc/internal/drizzle/DrizzleProtocol.java 2009-05-25 12:55:09 +0000
82@@ -37,7 +37,7 @@
83 * Time: 4:06:26 PM
84 */
85 public class DrizzleProtocol implements Protocol {
86- private final static Logger log = Logger.getLogger(DrizzleProtocol.class.toString());
87+ private final static Logger log = Logger.getLogger(DrizzleProtocol.class.getName());
88 private boolean connected=false;
89 private final Socket socket;
90 private final BufferedOutputStream writer;
91
92=== modified file 'src/main/java/org/drizzle/jdbc/internal/mysql/MySQLProtocol.java'
93--- src/main/java/org/drizzle/jdbc/internal/mysql/MySQLProtocol.java 2009-05-21 20:42:14 +0000
94+++ src/main/java/org/drizzle/jdbc/internal/mysql/MySQLProtocol.java 2009-05-25 12:55:09 +0000
95@@ -38,7 +38,7 @@
96 * Time: 4:06:26 PM
97 */
98 public class MySQLProtocol implements Protocol {
99- private final static Logger log = Logger.getLogger(MySQLProtocol.class.toString());
100+ private final static Logger log = Logger.getLogger(MySQLProtocol.class.getName());
101 private boolean connected=false;
102 private final Socket socket;
103 private final BufferedOutputStream writer;

Subscribers

People subscribed via source and target branches

to all changes: