Merge lp:~tribixbite/flashlight-firmware/moon-ramp-delay into lp:~toykeeper/flashlight-firmware/anduril2

Proposed by tribixbite
Status: Needs review
Proposed branch: lp:~tribixbite/flashlight-firmware/moon-ramp-delay
Merge into: lp:~toykeeper/flashlight-firmware/anduril2
Diff against target: 29 lines (+7/-1)
2 files modified
ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h (+1/-0)
ToyKeeper/spaghetti-monster/anduril/off-mode.c (+6/-1)
To merge this branch: bzr merge lp:~tribixbite/flashlight-firmware/moon-ramp-delay
Reviewer Review Type Date Requested Status
Selene ToyKeeper Pending
Review via email: mp+407425@code.launchpad.net

Commit message

Added MOON_RAMP_DELAY that defaults to 0 and is used to manually set a delay for hold-from-off to compensate for turn-on lag for level 1.
Set to 500ms (31) in cfg-noctigon-kr4.h.

To post a comment you must log in.

Unmerged revisions

614. By tribixbite

Added MOON_RAMP_DELAY that defaults to 0 and is used to manually set a delay for hold-from-off to compensate for turn-on lag for level 1.
Set to 500ms (31) in cfg-noctigon-kr4.h.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h'
--- ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h 2021-08-14 10:56:25 +0000
+++ ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h 2021-08-20 02:17:11 +0000
@@ -70,6 +70,7 @@
7070
71// the power regulator is a bit slow, so push it harder for a quick response from off71// the power regulator is a bit slow, so push it harder for a quick response from off
72#define JUMP_START_MOON 2672#define JUMP_START_MOON 26
73#define MOON_RAMP_DELAY 31
73#define BLINK_BRIGHTNESS DEFAULT_LEVEL74#define BLINK_BRIGHTNESS DEFAULT_LEVEL
74#define BLINK_ONCE_TIME 1275#define BLINK_ONCE_TIME 12
7576
7677
=== modified file 'ToyKeeper/spaghetti-monster/anduril/off-mode.c'
--- ToyKeeper/spaghetti-monster/anduril/off-mode.c 2021-08-12 09:02:50 +0000
+++ ToyKeeper/spaghetti-monster/anduril/off-mode.c 2021-08-20 02:17:11 +0000
@@ -129,7 +129,12 @@
129 // give the user time to release at moon level129 // give the user time to release at moon level
130 //if (arg >= HOLD_TIMEOUT) { // smaller130 //if (arg >= HOLD_TIMEOUT) { // smaller
131 if (arg >= (!ramp_style) * HOLD_TIMEOUT) { // more consistent131 if (arg >= (!ramp_style) * HOLD_TIMEOUT) { // more consistent
132 set_state(steady_state, 1);132 #ifndef MOON_RAMP_DELAY
133 #define MOON_RAMP_DELAY 0
134 #endif
135 if (arg > MOON_RAMP_DELAY) {
136 set_state(steady_state, 1);
137 }
133 }138 }
134 return MISCHIEF_MANAGED;139 return MISCHIEF_MANAGED;
135 }140 }

Subscribers

People subscribed via source and target branches

to status/vote changes: