Merge lp:~tribixbite/flashlight-firmware/moon-ramp-delay into lp:~toykeeper/flashlight-firmware/anduril2

Proposed by tribixbite
Status: Needs review
Proposed branch: lp:~tribixbite/flashlight-firmware/moon-ramp-delay
Merge into: lp:~toykeeper/flashlight-firmware/anduril2
Diff against target: 29 lines (+7/-1)
2 files modified
ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h (+1/-0)
ToyKeeper/spaghetti-monster/anduril/off-mode.c (+6/-1)
To merge this branch: bzr merge lp:~tribixbite/flashlight-firmware/moon-ramp-delay
Reviewer Review Type Date Requested Status
Selene ToyKeeper Pending
Review via email: mp+407425@code.launchpad.net

Commit message

Added MOON_RAMP_DELAY that defaults to 0 and is used to manually set a delay for hold-from-off to compensate for turn-on lag for level 1.
Set to 500ms (31) in cfg-noctigon-kr4.h.

To post a comment you must log in.

Unmerged revisions

614. By tribixbite

Added MOON_RAMP_DELAY that defaults to 0 and is used to manually set a delay for hold-from-off to compensate for turn-on lag for level 1.
Set to 500ms (31) in cfg-noctigon-kr4.h.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h'
2--- ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h 2021-08-14 10:56:25 +0000
3+++ ToyKeeper/spaghetti-monster/anduril/cfg-noctigon-kr4.h 2021-08-20 02:17:11 +0000
4@@ -70,6 +70,7 @@
5
6 // the power regulator is a bit slow, so push it harder for a quick response from off
7 #define JUMP_START_MOON 26
8+#define MOON_RAMP_DELAY 31
9 #define BLINK_BRIGHTNESS DEFAULT_LEVEL
10 #define BLINK_ONCE_TIME 12
11
12
13=== modified file 'ToyKeeper/spaghetti-monster/anduril/off-mode.c'
14--- ToyKeeper/spaghetti-monster/anduril/off-mode.c 2021-08-12 09:02:50 +0000
15+++ ToyKeeper/spaghetti-monster/anduril/off-mode.c 2021-08-20 02:17:11 +0000
16@@ -129,7 +129,12 @@
17 // give the user time to release at moon level
18 //if (arg >= HOLD_TIMEOUT) { // smaller
19 if (arg >= (!ramp_style) * HOLD_TIMEOUT) { // more consistent
20- set_state(steady_state, 1);
21+ #ifndef MOON_RAMP_DELAY
22+ #define MOON_RAMP_DELAY 0
23+ #endif
24+ if (arg > MOON_RAMP_DELAY) {
25+ set_state(steady_state, 1);
26+ }
27 }
28 return MISCHIEF_MANAGED;
29 }

Subscribers

People subscribed via source and target branches

to status/vote changes: