Merge lp:~tribaal/livecd-rootfs/xenial-proposed-minimized-round-two into lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed

[Chris Glass]

This branch is a backport of changes made in https://code.launchpad.net/~vorlon/livecd-rootfs/minimize-round-two/+merge/332529 to Xenial.

It further reduces the size of "minimized" (the ubuntu-cpc subproject) images, by removing some unneeded packages and files.

[Steve Langasek (vorlon)]

Just one change requested.

review: Needs Fixing

[lp:~tribaal/livecd-rootfs/xenial-proposed-minimized-round-two]

1445. By Chris Glass on 2017-11-14

* Remove apt, debconf, dpkg cruft files from /var/cache and /var/lib in
  all our livefses.
* Pass --cache false to lb config; otherwise we copy around caches of
  .debs that are never used properly, and which prevent us from emptying
  /var/cache/apt in images.
* When building minimized cloud images, remove various packages that we
  don't want installed by default. Some are tools that aren't needed for
  non-interactive use; some are libraries whose reverse-dependencies
  will have already been removed; and one, open-vm-tools, should only be
  included in images that are targeted to VMWare (which is not the case
  for any of the current minimal images), rather than being included
  directly in the cloud-image seed.

(expanded changelog)

[Chris Glass (tribaal)]

Changelog updated - this branch is ready for re-review.

=== modified file 'debian/changelog'
--- debian/changelog	2017-11-08 11:35:06 +0000
+++ debian/changelog	2017-11-14 07:45:33 +0000
@@ -1,3 +1,21 @@
+livecd-rootfs (2.408.24) UNRELEASED; urgency=medium
+
+  * Backport "minimized round 2" changes from trunk to Xenial (LP: #1731492)
+  * Remove apt, debconf, dpkg cruft files from /var/cache and /var/lib in
+    all our livefses.
+  * Pass --cache false to lb config; otherwise we copy around caches of
+    .debs that are never used properly, and which prevent us from emptying
+    /var/cache/apt in images.
+  * When building minimized cloud images, remove various packages that we
+    don't want installed by default.  Some are tools that aren't needed for
+    non-interactive use; some are libraries whose reverse-dependencies
+    will have already been removed; and one, open-vm-tools, should only be
+    included in images that are targeted to VMWare (which is not the case
+    for any of the current minimal images), rather than being included
+    directly in the cloud-image seed.
+
+ -- Christopher Glass (Ubuntu) <[e-mail]>  Fri, 10 Nov 2017 18:39:52 +0100
+
 livecd-rootfs (2.408.23) UNRELEASED; urgency=medium
 
   [ Gary Wang ]
 
=== modified file 'live-build/auto/build'
--- live-build/auto/build	2017-10-22 03:53:00 +0000
+++ live-build/auto/build	2017-11-14 07:45:33 +0000
@@ -166,6 +166,10 @@
 		rm -f chroot/boot/initrd.img-*
 	fi
 
+	# remove crufty files that shouldn't be left in an image
+	rm -f chroot/var/cache/debconf/*-old chroot/var/lib/dpkg/*-old
+	Chroot chroot apt clean
+
 	if [ -f config/oem-config-preinstalled ]; then
 
 # This is cargo-culted almost verbatim (with some syntax changes for
 
=== modified file 'live-build/auto/config'
--- live-build/auto/config	2017-11-08 11:35:06 +0000
+++ live-build/auto/config	2017-11-14 07:45:33 +0000
@@ -676,6 +676,7 @@
 	--initsystem none \
 	--bootloader "$BOOTLOADER" \
 	--initramfs-compression lzma \
+	--cache false \
 	${BOOTAPPEND_LIVE:+--bootappend-live "$BOOTAPPEND_LIVE"} \
 	$OPTS \
 	"$@"
 
=== modified file 'live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot'
--- live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot	2017-10-21 06:10:26 +0000
+++ live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot	2017-11-14 07:45:33 +0000
@@ -160,6 +160,27 @@
 	rm "${rootd}/boot/initrd.img"
 fi
 
+if [ "${SUBPROJECT:-}" = minimized ]; then
+	# Remove various packages that we don't want in the minimized images.
+	# Some of these are tools that don't make sense by default
+	# non-interactively; some are libraries whose reverse-dependencies
+	# will have already been removed; open-vm-tools, it's a bug that this
+	# is in the common cloud seed because this should only be included
+	# in VMWare guest images, and we know none of the minimized images
+	# are targeted at VMWare.
+	_xchroot "${rootd}" env DEBIAN_FRONTEND=noninteractive \
+		apt-mark auto '^lib.*' '^python*' vim-runtime 2>/dev/null
+	# FIXME: iso-codes is a dep of software-properties and shouldn't be
+	_xchroot "${rootd}" env DEBIAN_FRONTEND=noninteractive \
+		apt-get -y autoremove --purge iso-codes xauth pastebinit \
+		plymouth open-vm-tools git shared-mime-info vim vim-common \
+		console-setup ncurses-term tmux screen policykit-1 \
+		xdg-user-dirs less run-one apport-symptoms \
+		ubuntu-cloudimage-keyring file
+
+	_xchroot "${rootd}" apt clean
+fi
+
 #### END COMMON ARCH FUNCTIONS