Code review comment for lp:~tribaal/landscape-client/fix-1130130-backwards-incompatible-messgae

Revision history for this message
Thomas Herve (therve) wrote :

[1]
+ # avaialble. We'll just assume it's False in that case.

Typo: available.

[2] I think I would keep a single get_active_device_info function, and change the message in the plugin instead. This would mean only calling get_active_interfaces once, only creating one socket, etc.

Thanks!

review: Needs Fixing

« Back to merge proposal