Code review comment for lp:~tribaal/landscape-client/fix-1045374-mount-storm-in-client-take-2

Revision history for this message
Thomas Herve (therve) wrote :

[1]
+ if filesystems_whitelist is None:
+ filesystems_whitelist = STABLE_FILESYSTEMS

You can directly make it the default of the function. Maybe use a frozen set to feel more comfortable.

[2]
+from landscape.lib.disk import (get_mount_info, get_filesystem_for_path,
+STABLE_FILESYSTEMS)

You don't need to pass the value anymore, so you don't have to import STABLE_FILESYSTEMS.

[3] pep8

landscape/sysinfo/disk.py:12:25: E225 missing whitespace around operator
landscape/sysinfo/disk.py:13:37: E225 missing whitespace around operator
landscape/sysinfo/disk.py:15:37: E225 missing whitespace around operator

Thanks!

review: Approve

« Back to merge proposal