Code review comment for lp:~tribaal/landscape-client/cleanup-dbus-dependencies

Looks good to me, basically +1.

I have some comments. [1] needs to be resolved, but the others are not dbus
related, so could go in another branch.

[1]

=== modified file 'debian/landscape-client.install'
--- debian/landscape-client.install 2012-03-05 14:11:42 +0000
+++ debian/landscape-client.install 2013-05-20 07:31:31 +0000
@@ -10,5 +10,4 @@
 usr/bin/landscape-is-cloud-managed
 usr/bin/landscape-dbus-proxy

Hmm, so what's the deal with landscape-dbus-proxy? It still depends on dbus.

[2]

# hardy only
 ifneq (,$(findstring $(dist_release),hardy))
- # We depend on bug-fixed versions of python-dbus and pycurl on hardy
- echo "extra:Depends=python-dbus" >> $(landscape_common_substvars)
- echo "extra:Depends=python-pycurl, hal" >> $(landscape_client_substvars)
+ # We depend on bug-fixed versions pycurl on hardy
+ echo "extra:Depends=python-pycurl" >> $(landscape_client_substvars)

We should clean up this part of the rules file, not to care about hardy anymore.

[3]

 ifeq (,$(filter $(dist_release),hardy lucid))
- # Starting natty, no more hal or dbus
  echo "extra:Depends=libpam-modules (>= 1.0.1-9ubuntu3)" >> $(landscape_common_substvars)
  echo "extra:Depends=python-pycurl, gir1.2-gudev-1.0 (>= 165-0ubuntu2), python-gi" >>

Are gir1.2-gudev-1.0 and python-gi needed for any of the non-ui packages?